-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with commerce 8.x-2.16 #223
Compatibility with commerce 8.x-2.16 #223
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cnovak Yes. The add credit products are only created for you in kickstart. In |
@cnovak The product type, and products, and other config only gets installed when you do it through the Kickstart installer. If you are installing the |
I do not understand above comments @arlina-espinoza @arshad , but @arlina-espinoza pointed out that you need to add apigee/apigee-devportal-kickstart-drupal#323 to see full functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated a few more times LGTM
While working on apigee/apigee-devportal-kickstart-drupal#319, I noticed some entity schemas changes of commerce entities, starting from
commerce 8.x-2.16
.This PR updates the
apigee_m10n_add_credit
module so that it is compatible with the latest Commerce release.Related: https://www.drupal.org/node/3090561