Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with commerce 8.x-2.16 #223

Merged

Conversation

arlina-espinoza
Copy link
Collaborator

While working on apigee/apigee-devportal-kickstart-drupal#319, I noticed some entity schemas changes of commerce entities, starting from commerce 8.x-2.16.
This PR updates the apigee_m10n_add_credit module so that it is compatible with the latest Commerce release.
Related: https://www.drupal.org/node/3090561

@googlebot googlebot added the cla: yes Indicates CLA has been signed label Feb 21, 2020
@shadcn shadcn added this to the 8.x-1.4 milestone Feb 25, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates CLA has not been signed and removed cla: yes Indicates CLA has been signed labels Feb 25, 2020
@shadcn
Copy link
Collaborator

shadcn commented Feb 26, 2020

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates CLA has been signed and removed cla: no Indicates CLA has not been signed labels Feb 26, 2020
Copy link
Collaborator

@cnovak cnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything installed correctly, but the "add credit" button is not on the prepaid balance page:

Screen Shot 2020-02-26 at 8 50 43 PM

The requirements were not completed:
Screen Shot 2020-02-26 at 8 50 49 PM

Is this expected?

@shadcn
Copy link
Collaborator

shadcn commented Feb 27, 2020

@cnovak Yes. The add credit products are only created for you in kickstart. In apigee_m10n they are shown as requirements only.

@arlina-espinoza
Copy link
Collaborator Author

arlina-espinoza commented Feb 27, 2020

@cnovak The product type, and products, and other config only gets installed when you do it through the Kickstart installer. If you are installing the apigee_m10n_add_credit module afterwards, you need to go through the setup in the requirements page.
Note: the "add credit products" requirement will show up after the "add credit product type" has been completed, because it is a prerequisite.

@cnovak
Copy link
Collaborator

cnovak commented Feb 27, 2020

I do not understand above comments @arlina-espinoza @arshad , but @arlina-espinoza pointed out that you need to add apigee/apigee-devportal-kickstart-drupal#323 to see full functionality.

Copy link
Collaborator

@cnovak cnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated a few more times LGTM

@arlina-espinoza
Copy link
Collaborator Author

Thanks @cnovak . Added a follow up ticket to improve the payment gateway setup: #227

@arlina-espinoza arlina-espinoza merged commit 04d6536 into apigee:8.x-1.x Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants