[#319] Refactor add credit module configuration. #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2020
cnovak
requested changes
Feb 27, 2020
There was a problem hiding this comment.
Added comments. Do we have instructions/issue to track doc changes that need to be done?
I believe we need:
- Kickstart docs: Update instructions for setting up monetization during installer
- Kickstart docs: Update/create how to install monetization after installing if not done during installer
- M10n docs: Update/create Steps needed to configure m10n
Can we add a ticket w/this info?
modules/custom/apigee_kickstart_m10n_add_credit/apigee_kickstart_m10n_add_credit.info.yml
Show resolved
Hide resolved
| @@ -97,6 +98,27 @@ public static function createPaymentGateway(array $values, array &$context) { | |||
| $context['results']['$gateway'] = $gateway; | |||
| $context['message'] = t('Created a default payment gateway.'); | |||
| } | |||
| catch (\Exception $exception) { | |||
There was a problem hiding this comment.
See message above, createPaymentGateway is not being called, but should be
|
@cnovak I've addressed the changes, could you review again please? |
This was referenced Feb 27, 2020
|
Added documentation issues: apigee/apigee-m10n-drupal#226 and #330. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs apigee/apigee-m10n-drupal#223 (Compatibility with commerce 8.x-2.16), and together fix #319 .
The
Apigee Kickstart Monetizationsubmodule of Kickstart (apigee_kickstart_m10n_add_credit) is a configuration only module, and it is meant to be enabled during the initial Drupal installation, in the monetization step if the "Enable Add Credit module" is checked. If so, the Kickstart installer provided supplemental initialization in code. If the module is enabled after the installer completed, the other logic isn't run.To solve this issue, efforts were made in the
apigee_m10nmodule to allow a simpler configuration post-installation, andapigee_m10n 8.x-1.3includes a way to configure the "Add credit" module in a simple way from a requirements page at:/admin/reports/requirementsapigee_m10nduring the install phase if "Enable Add Credit module" is checked.apigee_kickstart_m10n_add_creditsubmodule, as it's no longer needed, and removes the confusion of having a module that should not be installed after the initial installation.apigee_m10n_add_creditconfiguration page at:/admin/reports/requirements@drupalninja: To test:
Apigee Kickstart Monetizationmodule. Just enableapigee_m10n_add_credit(Apigee Monetization Add Credit), and complete the requirements listed under/admin/reports/requirements