Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monetization setup is not completed in Kickstart installation #309

Closed
cnovak opened this issue Jan 31, 2020 · 5 comments
Closed

Monetization setup is not completed in Kickstart installation #309

cnovak opened this issue Jan 31, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cnovak
Copy link
Collaborator

cnovak commented Jan 31, 2020

Description

When installing Kickstart, you can enable prepaid balance topup if it is a monetization enabled org:

kickstart-install-configure-m10n

Once installed, the prepaid balances still does not show up on the balances page until you go to the requirements module and finish the requirements steps:

  1. Add credit products
  2. Add Credit product type
  3. Commerce store
  4. Add to Cart form display
  5. Payment gateway

However, the requirements steps 1 -4 do not have anything needed to do but click a button. Only the Payment gateway requirement has any need to fill out a form.

Issues

  1. Why doesn't the Kickstart monetization take care of 1-4 for me instead of making me need to click through buttons in the requirement module steps? It does not ask for any additional information.
  2. The monetization installer screen also does not say anything about needing to finish steps later or link to documentation on what is left to do.
@cnovak cnovak added the enhancement New feature or request label Jan 31, 2020
@shadcn
Copy link
Contributor

shadcn commented Feb 3, 2020

Hmm it looks like there's a regression somewhere. Step 1, 2 and 3 are definitely covered in the installation.

See https://github.com/apigee/apigee-devportal-kickstart-drupal/blob/8.x-1.x/apigee_devportal_kickstart.install#L128

Step 4 should be easy to add. Step 5 will require a bit more work.

@shadcn shadcn self-assigned this Feb 3, 2020
@shadcn shadcn added this to the 8.x-1.10 milestone Feb 3, 2020
@cnovak
Copy link
Collaborator Author

cnovak commented Feb 4, 2020

We don't need to automate step5, just add a note in the installer telling user they will need to configure a payment gateway w/a link to our docs. In Drupal 7 if you did not install a payment gateway the system would still work FYI, just had no way to charge the user. Would be good to see how system behaves w/out payment gateway configured to make sure system does not crash, etc.

@shadcn
Copy link
Contributor

shadcn commented Feb 12, 2020

@cnovak I just ran an installation again to check this and Step 1 to 4 is covered by kickstart. The "Add to Cart form display" is handle via config here: https://github.com/apigee/apigee-devportal-kickstart-drupal/blob/8.x-1.x/modules/custom/apigee_kickstart_m10n_add_credit/config/install/core.entity_form_display.commerce_order_item.add_credit.add_to_cart.yml

As for the payment gateway, you need this to checkout.

Order_information___Apigee_Kickstart_-_Mozilla_Firefox

@arlina-espinoza
Copy link
Contributor

@cnovak I think this should also be fixed by #323 and apigee/apigee-m10n-drupal#223.

@shadcn
Copy link
Contributor

shadcn commented Feb 28, 2020

#323 and apigee/apigee-m10n-drupal#223 have been merged.

We have a follow-up ticket in apigee_m10n to create a test payment gateway: apigee/apigee-m10n-drupal#227

I'm going to mark this ticket as done. Feel free to re-open if not.

Thank you.

@shadcn shadcn closed this as completed Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants