Improve Patch Generation logic and add tests #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdemers
commented
Dec 7, 2023
scim-core/src/main/java/org/apache/directory/scim/core/repository/PatchGenerator.java
Outdated
Show resolved
Hide resolved
bdemers
commented
Dec 7, 2023
scim-core/src/main/java/org/apache/directory/scim/core/repository/PatchGenerator.java
Outdated
Show resolved
Hide resolved
bdemers
force-pushed
the
patch-gen-tests
branch
from
081350c to
87286fb
Compare
bdemers
changed the title
bdemers
commented
Dec 14, 2023
| @@ -201,6 +202,7 @@ private static List<Schema.Attribute> createAttributes(String urn, List<Field> f | |||
| log.debug("Attempting to set the attribute type, raw value = " + typeName); | |||
| switch (typeName) { | |||
| case STRING_TYPE_IDENTIFIER: | |||
| case STRING_TYPE: | |||
There was a problem hiding this comment.
I need to add an issue to make coverage is good here.
These issues likely only affect Extensions, but that is still important.
The issue I was seeing is one of the Test object Extensions has a list of strings. Without this fix that list was, the list was showing up as a complex type, and would not diff correctly
|
Before merging, i'll break this up into more isolated changes |
|
splitting this PR up, see: ##451 |
The json patch solution required seralizing objects, then processing them with zjsonpatch, and finally some heavy post processing. This new solution walks the tree schema attributes to calculate the diff directly. Class was moved to scim-tools, as it's not directly used by scim-server or scim-client. PatchGenerator could be used by a SCIM client to calculate diffs to send to a server Or to generate patch requests when testing a server. NOTE: There are some limitations, this implementation assumes any changes to an object in a collection modifies the whole object, this will alwasy trigger a REMOVE and ADD operation (instead of a REPLACE).
bdemers
force-pushed
the
patch-gen-tests
branch
from
eeccacf to
13f8718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests and thoughts for: #427
@joshuapsteele sorry, I thought I pushed this up the other day. this branch has problems, but hopefully it results in some thinking out loudAdd new diff implementation without the dependency on zjsonpatch