Replaced zjsonpatch based resource diffing with Attribute based solut…

…ion (#435)

The json patch solution required seralizing objects, then processing them with zjsonpatch, and finally some heavy post processing.

This new solution walks the tree schema attributes to calculate the diff directly.
Class was moved to scim-tools, as it's not directly used by scim-server or scim-client.
PatchGenerator could be used by a SCIM client to calculate diffs to send to a server
Or to generate patch requests when testing a server.

NOTE: There are some limitations, this implementation assumes any changes to an object in a collection modifies the whole object,
this will alwasy trigger a REMOVE and ADD operation (instead of a REPLACE).

scim-core/pom.xml

@@ -51,11 +51,6 @@
       <artifactId>jakarta.enterprise.cdi-api</artifactId>
       <scope>provided</scope>
     </dependency>
-    <dependency>
-      <groupId>com.flipkart.zjsonpatch</groupId>
-      <artifactId>zjsonpatch</artifactId>
-      <version>0.4.14</version>
-    </dependency>
     <dependency>
       <groupId>org.projectlombok</groupId>
       <artifactId>lombok</artifactId>

scim-spec/scim-spec-schema/src/main/java/org/apache/directory/scim/spec/schema/Schemas.java

@@ -39,6 +39,7 @@
 public final class Schemas {
 
   private static final String STRING_TYPE_IDENTIFIER = "class java.lang.String";
+  private static final String STRING_TYPE = "java.lang.String"; // TODO this is ugly
   private static final String CHARACTER_ARRAY_TYPE_IDENTIFIER = "class [C";
   private static final String BIG_C_CHARACTER_ARRAY_TYPE_IDENTIFIER = "class [Ljava.lang.Character;";
   private static final String INT_TYPE_IDENTIFIER = "int";
@@ -201,6 +202,7 @@ private static List<Schema.Attribute> createAttributes(String urn, List<Field> f
       log.debug("Attempting to set the attribute type, raw value = " + typeName);
       switch (typeName) {
         case STRING_TYPE_IDENTIFIER:
+        case STRING_TYPE:
         case CHARACTER_ARRAY_TYPE_IDENTIFIER:
         case BIG_C_CHARACTER_ARRAY_TYPE_IDENTIFIER:
           log.debug("Setting type to String");

scim-tools/pom.xml

@@ -37,15 +37,40 @@
       <artifactId>scim-spec-schema</artifactId>
     </dependency>
     <dependency>
-      <groupId>com.github.foodev</groupId>
-      <artifactId>jsondiff</artifactId>
-      <version>2.0.0</version>
+      <groupId>org.apache.directory.scimple</groupId>
+      <artifactId>scim-core</artifactId>
+    </dependency>
+
+    <dependency>
+      <groupId>org.apache.directory.scimple</groupId>
+      <artifactId>scim-test</artifactId>
+      <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>org.junit.jupiter</groupId>
       <artifactId>junit-jupiter</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-core</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-junit-jupiter</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.assertj</groupId>
+      <artifactId>assertj-core</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-simple</artifactId>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
 </project>