Handle Azure style Group member remove operations #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdemers
reviewed
Dec 12, 2023
| )); | ||
|
|
||
| ScimGroup updatedGroup = patchHandler.apply(group(), List.of(op)); | ||
| assertThat(updatedGroup.getMembers().size()).isEqualTo(3); |
There was a problem hiding this comment.
nit: may want to assert on the members of the to ensure member collection contains the expected new value
bdemers
reviewed
Dec 12, 2023
scim-core/src/test/java/org/apache/directory/scim/core/repository/PatchHandlerTest.java
Show resolved
Hide resolved
kjthorpe18
force-pushed
the
handle-azure-group-member-removes
branch
from
bb91953 to
9e04961
Compare
|
@kjthorpe18 Can you rebase one more time? |
kjthorpe18
force-pushed
the
handle-azure-group-member-removes
branch
from
3b762b5 to
cd7bd90
Compare
Detects Azure Quirk mode.
Azure uses an out of spec patch operation that does not use an express,
but instead uses a remove with a value. Detect this and convert it to an expression
{
"op":"remove",
"path":"members",
"value":[{
"value":"<id>"
}]
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure sends PATCH operations to remove members from a group of the following form:
This is not how the SCIM spec says how to remove a single member from a group, but should be easy enough to handle this case of request.
This PR adds a special case in the
DefaultPatchHandlerto convert these requests to the acceptable and spec-compliant form.