Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuration options for Kafka consumer groups #436

Merged

Conversation

Masterchen09
Copy link
Contributor

This PR adds configurable Kafka consumer groups to the Helm chart. With the exception of one consumer group, it is already possible today to configure the consumer groups via the extra environment variables (extraEnvs), unfortunately one of the environment variables (DATAHUB_UPGRADE_HISTORY_KAFKA_CONSUMER_GROUP_ID) is already present in the corresponding Deployment and can therefore not specified via the extra environment variables. Nonetheless similar to the configurable Kafka topics it would be great to have dedicated options for the consumer groups too.

Additionally this PR already uses three new environment variables added by another PR in the datahub-actions repository to also configure the consumer groups used by the default action pipelines. Of course the other PR has to be merged first and there must be a new release for the datahub-actions image, which must be used by the Helm chart so this will have any effect (this PR expects that this new release will be version v0.0.16, therefore this PR should not be merged until there is a new release!).

For the default values I have used the currently defined default values e.g. defined
here or here (I have simply searched for "KAFKA_CONSUMER_GROUP_ID" to get all consumer groups resp. the corresponding environment variables).

DATAHUB_UPGRADE_HISTORY_KAFKA_CONSUMER_GROUP_ID is a bit special in here: The three pods (datahub-gms, mae-consumer and mce-consumer) which are using this environment variable have different values defined, therefore there are three "subkeys" to configure each pod individually. Additionally the previous default value for each pod was defined using the release name of the chart, to be consistent with previous versions this logic is kept and the default value "next" to the Kafka listener (e.g., here) is not used.

This PR also solves #319.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

@github-actions github-actions bot added the stale label May 26, 2024
@Masterchen09 Masterchen09 force-pushed the configurable-consumer-groups branch 2 times, most recently from d4cbb88 to 82148d8 Compare May 26, 2024 13:24
@github-actions github-actions bot removed the stale label May 27, 2024
@Masterchen09 Masterchen09 force-pushed the configurable-consumer-groups branch from 82148d8 to 5e323c5 Compare June 6, 2024 17:33
@david-leifker david-leifker requested a review from darnaut June 6, 2024 22:19
@Masterchen09 Masterchen09 force-pushed the configurable-consumer-groups branch from 5e323c5 to 2f5965c Compare June 7, 2024 04:25
@Masterchen09
Copy link
Contributor Author

To make sure that this PR is not automatically closed - here’s a comment.

@Masterchen09 Masterchen09 force-pushed the configurable-consumer-groups branch 2 times, most recently from 6da3fd9 to 8f89eb8 Compare July 13, 2024 13:04
Copy link

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

@github-actions github-actions bot added the stale label Aug 13, 2024
@Masterchen09
Copy link
Contributor Author

To make sure that this PR is not automatically closed - here’s a comment...again...

@darnaut Here's a reminder regarding this PR. :-)

@github-actions github-actions bot removed the stale label Aug 14, 2024
Copy link

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

@github-actions github-actions bot added the stale label Sep 13, 2024
@Masterchen09 Masterchen09 force-pushed the configurable-consumer-groups branch from 8f89eb8 to b12a5c9 Compare September 16, 2024 09:07
@github-actions github-actions bot removed the stale label Sep 17, 2024
@oelazzou
Copy link

Hello, it is possible to push this PR, the fact of being able to configure prefixes allows me to solve problems on kafka which requires prefix namespace. @darnaut thank you

@Masterchen09 Masterchen09 force-pushed the configurable-consumer-groups branch from b12a5c9 to 92f446a Compare October 24, 2024 14:26
@schoeberlt
Copy link

Hi, we also have this issue so it would be really great to merge this

@geoHeil
Copy link

geoHeil commented Oct 28, 2024

Hi I also would need this functionality for my organization

Copy link

@geoHeil geoHeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanHolstien RyanHolstien merged commit 1edccec into acryldata:master Oct 31, 2024
1 check passed
@Masterchen09 Masterchen09 deleted the configurable-consumer-groups branch November 8, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants