fix(mce-consumer): add METADATA_CHANGE_LOG_KAFKA_CONSUMER_GROUP_ID environment variable to MCE consumer. #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Masterchen09
force-pushed
the
fix-mce-consumer-group-id
branch
2 times, most recently
from
9370589 to
f94744d
Compare
Masterchen09
changed the title
Masterchen09
force-pushed
the
fix-mce-consumer-group-id
branch
from
f94744d to
14f5df3
Compare
…vironment variable to MCE consumer.
Masterchen09
force-pushed
the
fix-mce-consumer-group-id
branch
from
14f5df3 to
d719742
Compare
Masterchen09
changed the title
david-leifker
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the MCE consumer is not consuming any topic using the consumer group ID of the MAE consumer (which would make no sense), it seems the MCE consumer needs the consumer group ID used by the MAE consumer for the KafkaThrottleFactory - I think this is something new and wasn't there half a year ago.
FYI @RyanHolstien: I am tagging you here because you merged my original PR #436 - I hope we can have this fix merged a bit sooner and don't have to wait almost half a year (or more than half a year?)...😅
Checklist