feat: add configuration for Kafka consumer groups via environment variables #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Masterchen09
force-pushed
the
configurable-consumer-groups
branch
from
1eeb094 to
ec9596b
Compare
jjoyce0510
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have configurable consumer groups, this PR introduces three new environment variables which are used for the names of the three existing pipelines - the names of the pipelines are used for the consumer groups:
DATAHUB_ACTIONS_INGESTION_EXECUTOR_CONSUMER_GROUP_ID (ingestion_executor)
DATAHUB_ACTIONS_SLACK_CONSUMER_GROUP_ID (datahub_slack_action)
DATAHUB_ACTIONS_TEAMS_CONSUMER_GROUP_ID (datahub_teams_action)
If the environment variables are not provided the existing pipeline names will be used by default.
There will be another PR in the datahub-helm repository which will use these environment variables.
edit: The other PR in the datahub-helm repository.