ZCS-11169: Upgraded log4j version to 2.17.1 and made respective changes #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimsuchitgupta
requested review from
prashantajari,
jiteshsojitra,
singhjitesh and
miteshsavani810
as code owners
gautamdg
requested review from
abhishekdeshmukh2209,
dasiyogesh,
k-kato,
preshitaagrawal,
shrutig0510 and
silentsakky
shrutig0510
reviewed
Apr 22, 2022
shrutig0510
reviewed
Apr 22, 2022
shrutig0510
reviewed
Apr 22, 2022
shrutig0510
reviewed
Apr 22, 2022
shrutig0510
reviewed
Apr 22, 2022
dasiyogesh
reviewed
Apr 22, 2022
dasiyogesh
reviewed
Apr 22, 2022
dasiyogesh
reviewed
Apr 22, 2022
shrutig0510
reviewed
May 11, 2022
shrutig0510
reviewed
May 11, 2022
shrutig0510
reviewed
May 12, 2022
shrutig0510
reviewed
May 12, 2022
shrutig0510
reviewed
May 12, 2022
shrutig0510
reviewed
May 12, 2022
shrutig0510
approved these changes
May 12, 2022
gautamdg
approved these changes
May 13, 2022
RakeshAMore
approved these changes
May 13, 2022
|
Changes looks good to me, approved! |
dasiyogesh
reviewed
May 13, 2022
dasiyogesh
reviewed
May 13, 2022
| } | ||
|
|
||
| protected Map<String, String> getData() throws IOException { | ||
|
|
dasiyogesh
reviewed
May 13, 2022
| String line; | ||
|
|
||
| try { | ||
|
|
dasiyogesh
reviewed
May 13, 2022
| bugQAContactMap.put(bugid, bugcontact); | ||
| mLogger.debug("bugQAContact: put " + line); | ||
| } | ||
|
|
dasiyogesh
reviewed
May 13, 2022
| reader = null; | ||
| } | ||
| } | ||
|
|
dasiyogesh
reviewed
May 13, 2022
| } | ||
|
|
||
| protected Map<String, BugState> getData() throws IOException { | ||
|
|
dasiyogesh
reviewed
May 13, 2022
| public static File mRoot = new File("."); | ||
|
|
||
| public static void usage(Options o) { | ||
|
|
dasiyogesh
reviewed
May 13, 2022
| HelpFormatter hf = new HelpFormatter(); | ||
| hf.printHelp("ResultsMain -h | -b <arg> -d <arg> [ -l <log4j> ]", o, true); | ||
| System.exit(1); | ||
|
|
dasiyogesh
reviewed
May 13, 2022
|
|
||
| mLogger.info(String.format("%s: executed %s, success %s, time %s, asserts %s", name, executed, success, | ||
| time, asserts)); | ||
| if (e.element("failure") != null |
These are all old files with empty lines, recently only indentation is corrected. Removing them is time consuming for these many files...Do we need to do this now? |
dasiyogesh
approved these changes
May 13, 2022
…ective code changes
abhishekdeshmukh2209
force-pushed
the
bugfix/ZCS-11169
branch
from
3e09a6b to
96f3948
Compare
|
Please squash commits and keep only to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue :- Upgrade log4j version to 2.17.1
Solution : Upgraded log4j version to 2.17.1, did necessary code changes as well as updated the property file as per 2.17.1.