Skip to content

Commit

Permalink
ZCS-11169 : removing extra lines
Browse files Browse the repository at this point in the history
  • Loading branch information
abhishekdeshmukh2209 committed May 13, 2022
1 parent 82011c8 commit 3e09a6b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 18 deletions.
3 changes: 0 additions & 3 deletions src/java/com/zimbra/qa/bugreports/BugQAContact.java
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ protected Map<String, String> getData() throws IOException {
String line;

try {

reader = new BufferedReader(new FileReader(getDatafile(DataFilename)));
while ((line = reader.readLine()) != null) {
// Example: 42337 [email protected]
Expand All @@ -50,14 +49,12 @@ protected Map<String, String> getData() throws IOException {
bugQAContactMap.put(bugid, bugcontact);
mLogger.debug("bugQAContact: put " + line);
}

} finally {
if (reader != null) {
reader.close();
reader = null;
}
}

return (bugQAContactMap);
}

Expand Down
14 changes: 3 additions & 11 deletions src/java/com/zimbra/qa/bugreports/BugStatus.java
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,9 @@
public class BugStatus extends BugDataFile {
private static final Logger mLogger = LogManager.getLogger(BugStatus.class);

public enum BugState {
UNCONFIRMED,
NEW,
ASSIGNED,
REOPENED,
IN_PROGRESS,
RESOLVED,
VERIFIED,
CLOSED
}
public enum BugState {
UNCONFIRMED, NEW, ASSIGNED, REOPENED, IN_PROGRESS, RESOLVED, VERIFIED, CLOSED
}

/**
* Return the current list of "Bug ID" to "Bug Status"
Expand Down Expand Up @@ -68,5 +61,4 @@ protected Map<String, BugState> getData() throws IOException {
}
return (bugStatusMap);
}

}
2 changes: 0 additions & 2 deletions src/java/com/zimbra/qa/bugreports/ResultsMain.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,9 @@ public class ResultsMain {
public static File mRoot = new File(".");

public static void usage(Options o) {

HelpFormatter hf = new HelpFormatter();
hf.printHelp("ResultsMain -h | -b <arg> -d <arg> [ -l <log4j> ]", o, true);
System.exit(1);

}

protected static void parseArgs(String[] args) {
Expand Down
3 changes: 1 addition & 2 deletions src/java/com/zimbra/qa/bugreports/TestCaseEngineNUnit.java
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ public List<TestCaseResult> getData() throws UnsupportedEncodingException, IOExc

mLogger.info(String.format("%s: executed %s, success %s, time %s, asserts %s", name, executed, success,
time, asserts));
if (e.element("failure") != null
&& e.element("failure").elementText("message").contains("SyncHarness.HarnessException"))
if (e.element("failure") != null && e.element("failure").elementText("message").contains("SyncHarness.HarnessException"))
results.add(new TestCaseResult(name, "exception"));
else {
// In nunit results, if the test case is ignored, the "executed" property of the
Expand Down

0 comments on commit 3e09a6b

Please sign in to comment.