-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rigid body continued #18
Conversation
### Desccription - Add missing `name` & `description` from package.json - Format vite config file
### Description - Uncomment & implement `trimesh` support - Add `heightfield` todo comment Co-Authored-By: Alvaro Saburido <[email protected]>
### Description - Correct `world` step usage - Correctly update the `timestep` - Use correct type for `useRapierContext` - Improve methods documentation Co-Authored-By: Alvaro Saburido <[email protected]>
Hey @alvarosabu, I'm planning to list the needed features and share them with you as discussed, |
### Description - Move `vue` components at `./src/components/` - Move all types/interfaces at `./src/types` - Add `RigidBodyType` type (containing the supported rigidBodyDesc types) - Add `RigidBodyProps` interface - Add `InjectableRapierContext` interface - Add `PhysicsProps` interface - Add `ColliderShape` type - Move helper/utils at `./src/utils/` - Rename `createColliderDesc` to `createColliderDesc`, and return a `ColliderDesc` - Rename `createRigidBody` to `createRigidBodyDesc` and return a `RigidBodyDesc` - Add a `./src/constants/` sub folder Co-Authored-By: Alvaro Saburido <[email protected]>
### Description - Add `createRigiBody` util - Add `CreateRigidBodyProps` type - `createRigidBodyDesc` need an object now - Add `CreateRigidBodyDescProps` type - `createColliderDesc ` need an object now - Add `CreateColliderDescProps ` type - Add `createCollider` util - Add `CreateColliderProps` type - Add `createColliderFromChildren` util - Add `CreateColliderFromChildrenProps` type - Map received children colliders and update their states
### Description - Add `convexHull` colliderDesc support
### Description - Add `instancedMesh` rigid-body position support - Add `instancedMesh` rigid-body rotation support - Make `createRigidBody` export the received `object` - Add `CreateRigidBodyReturnType` - Make `createCollider` export the received `object` - Add `CreateColliderReturnType`
Today I tried to implement the I'll wait for a review before continuing. I limited myself only to Support for all the collider shapes.We should implement more colliders like:
|
Hi @Neosoulink thanks for the contribution, I will go over it this week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Neosoulink it looks great already, thanks a lot, I tested it locally and works like charm.
There are some minor naming convention topics on the review (file redundant suffixes) + some types missing. The first one is basically to keep a standard within the ecosystem naming conventions.
Let me know if you have any questions.
### description - Remove redundant suffixes - Add missing types to callbacks params Co-Authored-By: Alvaro Saburido <[email protected]>
f483b4f
to
ec8d78d
Compare
Hey @alvarosabu, the requested changes were made ✨ |
@alvarosabu, I just merged the last changes from This branch is now ready, can can we merge it? |
Hey @alvarosabu I would like to make some work here, but I notice this PR. Can you provide me with access?. |
There are some merge conflicts still. @JaimeTorrealba |
Oh let me resolve them @alvarosabu @JaimeTorrealba, I wasn't aware of that |
I always prefer rebasing code from main branches but this one was too behind so I just merged code from I also updated this PR description adding records to see a bit how it looks. |
That's an excellent work @Neosoulink. |
Thanks, @JaimeTorrealba and please don't hesitate to reach me for any updates I see you changed the base, are you currently working on this branch? |
Not really, that was a mistake (I was using GitHub in my tablet I pressed something hehe, sorry) @Neosoulink I'll contact you by discord if you don't mind. |
Sure 😀, I'll appreciate sharing there |
About this PR
This PR adds some missing Physics support and some tiny documentation refactoring.
Change logs
instancedMesh
rigid-body position supportinstancedMesh
rigid-body rotation supportcreateRigidBody
export the receivedobject
CreateRigidBodyReturnType
createCollider
export the receivedobject
CreateColliderReturnType
instancedMesh
support | d68dd43EULER_ZERO
,QUATERNION_ZERO
,MATRIX_ZERO
)RigidBody
component acceptinstanced
boolean propertyRigidBody
componenthull
collider | 3b366f6hull
case tocreateColliderDesc
(convexHull
colliderDesc support)hull
toColliderShape
typecreateRigiBody
utilCreateRigidBodyProps
typecreateRigidBodyDesc
need an object nowCreateRigidBodyDescProps
typecreateColliderDesc
need an object nowCreateColliderDescProps
typecreateCollider
utilCreateColliderProps
typecreateColliderFromChildren
utilCreateColliderFromChildrenProps
typevue
components at./src/components/
./src/types
RigidBodyType
type (containing the supported rigidBodyDesc types)RigidBodyProps
interfaceInjectableRapierContext
interfacePhysicsProps
interfaceColliderShape
type./src/utils/
createColliderDesc
tocreateColliderDesc
, and return aColliderDesc
createRigidBody
tocreateRigidBodyDesc
and return aRigidBodyDesc
./src/constants/
sub folderworld
step usagetimestep
useRapierContext
trimesh
support | 96cd52atrimesh
supportheightfield
todo commentname
& description from package.jsonvite
config fileRecords
record-1.mov
record-2.mov