refactor(style): request changes improvements

### description - Remove redundant suffixes - Add missing types to callbacks params
Tresjs · Jun 29, 2024 · f483b4f · f483b4f
1 parent 274e067
commit f483b4f
Show file tree

Hide file tree

Showing 12 changed files with 15 additions and 15 deletions.
diff --git a/src/components/Physics.vue b/src/components/Physics.vue
@@ -2,7 +2,7 @@
 import { useLoop } from '@tresjs/core'
 
 import { useRapierContextProvider } from '../composables/useRapier'
-import type { PhysicsProps } from '../types/physics.type'
+import type { PhysicsProps } from '../types/physics'
 import Debug from './Debug.vue'
 
 withDefaults(

diff --git a/src/components/RigidBody.vue b/src/components/RigidBody.vue
@@ -4,11 +4,11 @@ import { type TresObject, useLoop } from '@tresjs/core'
 
 import { InstancedMesh } from 'three'
 import { useRapierContext } from '../composables/useRapier'
-import { createRigidBody } from '../utils/rigid-body.util'
-import { createCollider, createCollidersFromChildren } from '../utils/collider.util'
-import { MATRIX_ZERO, QUATERNION_ZERO, VECTOR_ZERO } from '../constants/object.constant'
-import type { CreateRigidBodyReturnType, RigidBodyProps } from '../types/rigid-body.type'
-import type { CreateColliderReturnType } from '../types/collider.type'
+import { createRigidBody } from '../utils/rigid-body'
+import { createCollider, createCollidersFromChildren } from '../utils/collider'
+import { MATRIX_ZERO, QUATERNION_ZERO, VECTOR_ZERO } from '../constants/object'
+import type { CreateRigidBodyReturnType, RigidBodyProps } from '../types/rigid-body'
+import type { CreateColliderReturnType } from '../types/collider'
 
 const props = withDefaults(defineProps<Partial<RigidBodyProps>>(), {
   type: 'dynamic',
@@ -23,7 +23,7 @@ const parentObject = shallowRef<TresObject>()
 const rigidBodyInfos = shallowRef<CreateRigidBodyReturnType[]>()
 const colliderInfos = shallowRef<CreateColliderReturnType[]>()
 
-watch(parentObject, (object) => {
+watch(parentObject, (object?: TresObject) => {
   if (!object) { return }
 
   if (props.instanced) {
@@ -120,7 +120,7 @@ onBeforeRender(() => {
     return
   }
 
-  rigidBodyInfos.value.forEach((item) => {
+  rigidBodyInfos.value.forEach((item: CreateRigidBodyReturnType) => {
     const position = item.rigidBody.translation()
     item.object.position.set(position.x, position.y, position.z)
 

diff --git a/src/composables/useRapier.ts b/src/composables/useRapier.ts
@@ -1,7 +1,7 @@
 import { inject, provide } from 'vue'
 
-import { GRAVITY } from '../constants/physics.constant'
-import type { RapierContext } from '../types/rapier.type'
+import { GRAVITY } from '../constants/physics'
+import type { RapierContext } from '../types/rapier'
 
 /**
  * @description Provides the `RapierContext` provider.

diff --git a/src/constants/object.constant.ts → src/constants/object.ts b/src/constants/object.constant.ts → src/constants/object.ts
diff --git a/src/constants/physics.constant.ts → src/constants/physics.ts b/src/constants/physics.constant.ts → src/constants/physics.ts
diff --git a/src/core/injectionKeys.ts b/src/core/injectionKeys.ts
@@ -1,6 +1,6 @@
 import type { InjectionKey, ShallowRef } from 'vue'
 
-import type { InjectableRapierContext } from '../types/rapier.type'
+import type { InjectableRapierContext } from '../types/rapier'
 
 export const rapierInjectionKey: InjectionKey<
   ShallowRef<InjectableRapierContext | null>

diff --git a/src/types/collider.type.ts → src/types/collider.ts b/src/types/collider.type.ts → src/types/collider.ts
diff --git a/src/types/physics.type.ts → src/types/physics.ts b/src/types/physics.type.ts → src/types/physics.ts
diff --git a/src/types/rapier.type.ts → src/types/rapier.ts b/src/types/rapier.type.ts → src/types/rapier.ts
diff --git a/src/types/rigid-body.type.ts → src/types/rigid-body.ts b/src/types/rigid-body.type.ts → src/types/rigid-body.ts
@@ -2,7 +2,7 @@ import type { TresObject } from '@tresjs/core'
 import type { RigidBody, RigidBodyDesc, World } from '@dimforge/rapier3d-compat'
 import type { InstancedMesh } from 'three'
 
-import type { ColliderShape } from './collider.type'
+import type { ColliderShape } from './collider'
 
 /** @description Tres Rapier supported `RigidBody` types. */
 export type RigidBodyType =

diff --git a/src/utils/collider.util.ts → src/utils/collider.ts b/src/utils/collider.util.ts → src/utils/collider.ts
@@ -2,13 +2,13 @@ import { ColliderDesc } from '@dimforge/rapier3d-compat'
 import { mergeVertices } from 'three/examples/jsm/utils/BufferGeometryUtils.js'
 import type { TresObject } from '@tresjs/core'
 
-import { VECTOR_ZERO } from '../constants/object.constant'
+import { VECTOR_ZERO } from '../constants/object'
 import type {
   CreateColliderDescProps,
   CreateColliderProps,
   CreateColliderReturnType,
   CreateCollidersFromChildrenProps,
-} from '../types/collider.type'
+} from '../types/collider'
 
 /**
  * @description Create a {@link ColliderDesc} shape based on the given

diff --git a/src/utils/rigid-body.util.ts → src/utils/rigid-body.ts b/src/utils/rigid-body.util.ts → src/utils/rigid-body.ts
@@ -4,7 +4,7 @@ import type {
   CreateRigidBodyDescProps,
   CreateRigidBodyProps,
   CreateRigidBodyReturnType,
-} from '../types/rigid-body.type'
+} from '../types/rigid-body'
 
 /**
  * @description Create a {@link RigidBodyDesc} based on the given