Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of the cancellation process in Tapir #495
Implementation of the cancellation process in Tapir #495
Changes from 3 commits
54bcc30
13cfdea
18dd282
4cf16fc
db80976
2421aa9
553c3d5
a14e639
0f8bb1c
9cdcb5b
57c0cba
453e942
d5908e8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could all the migrations be merged into a single file? Or there are 9 logically separate changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure to understand how to merge migrations files into one? I make the command "make migrations" and django puts out these single files. If you could tell me how to merge migrations files ....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, these are created automatically (mixed it with my Java project, where these files are written by hand).
Would it be possible to remove them and run make migrations afterwards? Maybe then they would become a single file. Not sure though, so we may keep it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put them in the PR, so nobody would have to make a migration on the server. And the migrations files are on GitHub also as single files in there. Also we have a bug when making a migrations as I discussed with Théo. It makes all the time a needless files in the account-app. If you want to make your own makemigrations command you'll have to delete this file first.
This comment was marked as resolved.
Sorry, something went wrong.