Implementation of the cancellation process in Tapir #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tvedeane
reviewed
May 24, 2024
tvedeane
reviewed
May 24, 2024
tvedeane
reviewed
May 24, 2024
tvedeane
reviewed
May 24, 2024
tvedeane
reviewed
May 24, 2024
tvedeane
reviewed
May 24, 2024
tvedeane
reviewed
May 24, 2024
tvedeane
reviewed
May 24, 2024
tvedeane
reviewed
May 24, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
I'd add extra spacing in the marked spot (compare with other pages, where there is more margin). |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…hifts (regarding safe area)" This reverts commit 18dd282.
tvedeane
requested changes
Jun 1, 2024
| import django.utils.timezone | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
tvedeane
reviewed
Jun 2, 2024
| @@ -205,8 +205,6 @@ def share_ownership_delete(request, pk): | |||
| share_ownership.delete() | |||
|
|
|||
| return redirect(share_owner) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
You don't need to touch this file (i.e. shouldn't be part of this PR).
tvedeane
reviewed
Jun 2, 2024
tvedeane
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first (hopefully) working version of cancelling a member on Tapir, located (as the membership pause) in the "Member management" area.