Update from original #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move_base_msgs is a rather standard package, that comes with the navigation stack
The 'JointPositions' message is not standard and actually it is now hard to find references to it on the Web. The corresponding MORSE class (JointPositionsReader) does not seem to be used anyway with any of the sensors. Relates to bug #645
Make it more explicit in case the package (asctec_msgs) is missing Related to #645
We still need to ship our own tfMessage as, in my testing, 'from tf.msg import tfMessage' fails in Python3
It means that the logic step by simulated second is constant, and so that basically sensors are refreshed at the same period (in simulated time)
While here, fix a typo in service call, and make it clear that the sentence is still true for the next-to-come 1.4
It allows to computes movement of the quadrotor on the basis on its four propellers speed
Kill MavlinkClient which is now unused Make sensor and actuator more symetric, with the same setup method
Update the values used to detected green box. This change is probably needed due to use of SINGLETEXTURE instead of MULTITEXTURE since age.
XXX Still not sure why it improves the consistency of the tests, but it definitively helps.
It allows to change period of the syncer, or to properly quit the session. Can be used both by an user, or a programm
Depth Camera seems badly broken with it
Accessing through local_data makes an un-understandable conversion to something like a string
This sensor takes the input of several depth_camera and merge it in one point cloud
Nowadays, it is not too extravagant to use C99 code ...
…process Other lines will be discarded, allowing to better simulate sparse sensor such as 3D Lidar
Pass from 3ms in mean to something like 0.6ms in mean.
While here, modify cam_focal to reduce place covered twice
ExternalForce was not working with ros. Turns out the datastream interface key for ExternalForce was incorrect: it is `external_force` instead of `externalForce` as the name of python file and as described [here](https://github.com/morse-simulator/morse/blob/86f3793afcdb0f9bf0eb26435ef04f0518ab1f6f/src/morse/builder/actuators.py#L330)
…tion an option to keep the exact number of points (according to the camera resolution) has been added.
`async` became a keyword in python 3.7
…al reason is unclear.
However, the included simplification of the create_new_material() method solved the problem.
The original problem stack trace was the following:
Exception ignored in: <bound method Environment.__del__ of <morse.builder.environment.Environment object at 0x7f94cce4a908>>
Traceback (most recent call last):
File "/usr/local/lib/python3/dist-packages/morse/builder/environment.py", line 831, in __del__
self.create()
File "/usr/local/lib/python3/dist-packages/morse/builder/environment.py", line 300, in create
component.after_renaming()
File "/usr/local/lib/python3/dist-packages/morse/builder/sensors.py", line 290, in after_renaming
self.create_laser_arc()
File "/usr/local/lib/python3/dist-packages/morse/builder/sensors.py", line 283, in create_laser_arc
arc.active_material = self.get_ray_material()
File "/usr/local/lib/python3/dist-packages/morse/builder/sensors.py", line 186, in get_ray_material
ray_material = bpymorse.create_new_material()
File "/usr/local/lib/python3/dist-packages/morse/builder/bpymorse.py", line 96, in create_new_material
material_name = [name for name in get_materials().keys() \
IndexError: pop from empty list
…e frame and in world frame Use everything in the vehicle frame.
While here, simplify a bit the whole sensor computation
…r instead of a TwistStamped Keep the previous one for compatibility, but one should use Velocity sensor if it needs velocity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.