Document highlight shouldn't include the block for a method invocation #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/fix-block-highlighting
branch
from
9252aa4 to
c581617
Compare
andyw8
added
the
server
andyw8
commented
Jul 24, 2024
vinistock
reviewed
Jul 25, 2024
There was a problem hiding this comment.
If I understand the issue correctly, the problem was more related to the DefNode than the CallNode. I think we might be highlighting the entire method declaration instead of just its name.
The call node changes are good too, but we need the def node handling to be improved to fix the reported issue.
andyw8
force-pushed
the
andyw8/fix-block-highlighting
branch
2 times, most recently
from
18b9a1c to
571b7db
Compare
andyw8
force-pushed
the
andyw8/fix-block-highlighting
branch
2 times, most recently
from
1cf9387 to
6bc9b93
Compare
vinistock
approved these changes
Jul 25, 2024
andyw8
force-pushed
the
andyw8/fix-block-highlighting
branch
from
6bc9b93 to
67494f4
Compare
andyw8
changed the title
st0012
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2332
Implementation
Highlight only the invocation's name, not its block.
Automated Tests
Added a new fixture and expectation.
Manual Tests
Open the fixture, move the cursor over
fooand ensure only thefoopart is highlighted in all invocations.