Document highlight shouldn't include the block for a method

Shopify · Jul 24, 2024 · 9252aa4 · 9252aa4
1 parent c36f1c2
commit 9252aa4
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 1 deletion.
diff --git a/lib/ruby_lsp/listeners/document_highlight.rb b/lib/ruby_lsp/listeners/document_highlight.rb
@@ -180,7 +180,7 @@ def initialize(response_builder, target, parent, dispatcher)
       def on_call_node_enter(node)
         return unless matches?(node, [Prism::CallNode, Prism::DefNode])
 
-        add_highlight(Constant::DocumentHighlightKind::READ, node.location)
+        add_highlight(Constant::DocumentHighlightKind::READ, node.message_loc)
       end
 
       sig { params(node: Prism::DefNode).void }

diff --git a/test/expectations/document_highlight/highlight.exp.json b/test/expectations/document_highlight/highlight.exp.json
@@ -0,0 +1,36 @@
+{
+    "result": [
+        {
+            "range": {
+                "start": {
+                    "line": 0,
+                    "character": 0
+                },
+                "end": {
+                    "line": 0,
+                    "character": 3
+                }
+            },
+            "kind": 2
+        },
+        {
+            "range": {
+                "start": {
+                    "line": 3,
+                    "character": 0
+                },
+                "end": {
+                    "line": 3,
+                    "character": 3
+                }
+            },
+            "kind": 2
+        }
+    ],
+    "params": [
+        {
+            "line": 0,
+            "character": 2
+        }
+    ]
+}
diff --git a/test/fixtures/highlight.rb b/test/fixtures/highlight.rb
@@ -0,0 +1,5 @@
+foo do
+end
+
+foo do
+end
-Original file line number
+Diff line change
@@ -0,0 +1,5 @@
+    foo do
+    end
+    foo do
+    end