Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable method highlighting #2332

Closed
1 task done
ksweetie opened this issue Jul 18, 2024 · 2 comments · Fixed by #2357
Closed
1 task done

Disable method highlighting #2332

ksweetie opened this issue Jul 18, 2024 · 2 comments · Fixed by #2357
Assignees
Labels
enhancement New feature or request

Comments

@ksweetie
Copy link

I have checked that this feature is not already implemented

  • This feature does not exist

Use case

(I think this is relevant to ruby-lsp, but if not let me know where I can post an issue to. Also wanted to say thanks for the awesome project—I switched to it several months ago and have been very happy with the experience!)

When the cursor is on a method invocation, it highlights that entire method call (and block), as well as every other invocation of the same method. Often times, I'm working in files that repeatedly call the same method. For example, test files where each test is in a method call block. The result is that my entire file is essentially highlighted when the cursor is on the method name. It makes the contrast worse, so the code is harder to read, and it's really distracting to have the entire file flip back and forth from unhighlighted to highlighted, etc.

Video in vscode:

Screen.Recording.2024-07-18.at.11.45.12.AM.mov

The same problem exists in Zed:
Screen Shot 2024-07-18 at 11 41 06 AM

Description

I'm not sure what makes the most sense. I don't find this type of method highlighting useful, but I imagine there are others who do. Could it be an option to disable it?

For vscode, you can prevent this by setting "editor.occurrencesHighlight": "off", but that disables all occurrences highlighting, like variables, which I do find useful.

I haven't found a way to disable method highlighting in Zed.

Implementation

No response

@andyw8
Copy link
Contributor

andyw8 commented Jul 25, 2024

@ksweetie thanks for reporting, #2357 will resolve this.

@ksweetie
Copy link
Author

@andyw8 I really appreciate the quick turnaround, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants