feat(wasm): Import/export account #893

Flemmli97 · 2024-11-27T16:44:00Z

What this PR does 📖

Adds ability to import/export accounts
Importing:
- At login screen: Clicking on import brings up pin page to type in a new pin.
- Continuing brings up a passphrase page where the user can either type the passphrase in or upload from a file. Words in the file can be separated by either a newline or whitespace
- Importing can be done either via remote (dont think its enabled yet) or from a file
Exporting:
- Adds ability to export in the profile settings page. Either to remote or to a file. If remote is enabled at some point that should also be done automatically. The button is there if someone wants to manually do it too

Which issue(s) this PR fixes 🔨

Resolve feat(import): wire in Import account in UplinkWeb #816

Special notes for reviewers 🗒️

A lot of errors are due to wasm update which is handled in #868. I just didnt include the stuff in that pr here too. So ideally merge #868 first

github-actions · 2024-11-27T16:48:09Z

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

github-actions · 2024-11-27T16:52:18Z

Download the app installers for this pull request:

stavares843

go to import > dont import > back > sign up > add name > error

Gravacao.do.ecra.2024-11-27.as.18.25.45.mov

chrome, macOS

stavares843

Captura de ecrã 2024-11-27, às 18 27 12

i made a new account
settings
export to both file and remote
deleted account
import
add seed
use file

says identity does not exist - does that mean it was really removed?

Flemmli97 · 2024-11-28T17:34:10Z

i made a new account settings export to both file and remote deleted account import add seed use file
says identity does not exist - does that mean it was really removed?

does import still work? it might be because warp instances are still dangling around with some polling stuff. the way i tested it just open a new incognito tab and import there. that way all dangling data is gone

stavares843 · 2024-11-28T17:54:25Z

does import still work?

when i delete account no

dariusc93

lgtm. left a small comment and a suggestion

Though testing has been done by QA to confirm that importing and exporting does work, it is still a WIP to finish up other aspects of it as well as clearing up some additional bugs, hence why shuttle will be disabled by default for now while changes are being made. We could block this PR until it is done or we could merge it in with it disabled until. a dev flag is in place to enable or disable it.

Thoughts @phillsatellite @stavares843 @Flemmli97 ?

dariusc93 · 2024-12-11T14:01:48Z

src/lib/wasm/MultipassStore.ts

@@ -620,6 +620,30 @@ class MultipassStore {
        }
    }

+    async importAccount(passphrase: string, settings?: { to?: Uint8Array; multipassBox?: wasm.MultiPassBox }): Promise<Result<WarpError, wasm.Identity | undefined>> {
+        let multipass = settings?.multipassBox ? settings.multipassBox : get(this.multipassWritable)


wouldnt it be best to use get(this.multipassWritable) altogether?

this is because atm during import a temp warp instance is created
i guess we could just remove using the stored instance though since that atm is never used? thoughts?

src/lib/wasm/WarpStore.ts

Co-authored-by: Darius Clark <[email protected]>

stavares843 · 2024-12-16T10:18:29Z

shuttle will be disabled by default

But that means no messages are available on the import

stavares843 · 2024-12-16T18:38:34Z

if you use any other file instead of the seed one, you will get these mambojambo on the screen

flow

use backup file to import as a seed
appears like that

phillsatellite · 2024-12-19T16:46:53Z

The bug @stavares843 commented is now fixed. I put the blocked label until we get the remote import account working

Flemmli97 added 4 commits November 25, 2024 18:06

import ui

ee77490

add export to profile settings

f7ccdfb

finishing up account import

8c93a9f

typo

74eb74f

github-actions bot assigned Flemmli97 Nov 27, 2024

github-actions bot added the Missing dev review Two dev reviews are required on PR label Nov 27, 2024

Flemmli97 and others added 2 commits November 27, 2024 18:03

Merge branch 'dev' into import/export_account

f13fe55

Merge branch 'dev' into import/export_account

dde7368

github-actions bot added the Failed Automated Test Failed Automated Tests CI label Nov 27, 2024

Merge branch 'dev' into import/export_account

53c0bd8

stavares843 removed the Failed Automated Test Failed Automated Tests CI label Nov 27, 2024

stavares843 requested changes Nov 27, 2024

View reviewed changes

stavares843 reviewed Nov 27, 2024

View reviewed changes

stavares843 added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Nov 27, 2024

This comment was marked as outdated.

Sign in to view

github-actions bot added the Failed Automated Test Failed Automated Tests CI label Nov 27, 2024

stavares843 removed the Failed Automated Test Failed Automated Tests CI label Nov 27, 2024

stavares843 added 4 commits November 27, 2024 21:05

Merge branch 'dev' into import/export_account

aedbfa0

Merge branch 'dev' into import/export_account

ef69fd5

Merge branch 'dev' into import/export_account

b5a9f25

Merge branch 'dev' into import/export_account

84e2546

github-actions bot added the Failed Automated Test Failed Automated Tests CI label Nov 27, 2024

Flemmli97 added 3 commits November 28, 2024 18:24

clear tesseract instance when going back

93e1ddf

change file extension

7679900

remove log

b2dad02

stavares843 removed the Failed Automated Test Failed Automated Tests CI label Nov 28, 2024

allow paste spreading

5b4dd37

Flemmli97 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Dec 13, 2024

Merge branch 'dev' into import/export_account

bdd940c

stavares843 removed the Failed Automated Test Failed Automated Tests CI label Dec 13, 2024

github-actions bot added the Failed Automated Test Failed Automated Tests CI label Dec 13, 2024

Flemmli97 and others added 2 commits December 13, 2024 19:02

Merge branch 'dev' into import/export_account

a99572b

Merge branch 'dev' into import/export_account

4a8e489

github-actions bot removed the Failed Automated Test Failed Automated Tests CI label Dec 13, 2024

dariusc93 approved these changes Dec 14, 2024

View reviewed changes

dariusc93 and others added 2 commits December 14, 2024 12:34

Merge branch 'dev' into import/export_account

e162b73

Update src/lib/wasm/WarpStore.ts

cfbf45a

Co-authored-by: Darius Clark <[email protected]>

This was referenced Dec 16, 2024

feat(community): Add Communities api #935

Merged

feat(friends): Allow quick add friend from link #906

Open

Merge branch 'dev' into import/export_account

31b21d1

phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Dec 17, 2024

stavares843 and others added 5 commits December 17, 2024 19:53

Merge branch 'dev' into import/export_account

587b81e

Merge branch 'dev' into import/export_account

d142bb7

Merge branch 'dev' into import/export_account

4820fe2

Merge branch 'dev' into import/export_account

438235d

file filter to import

7d1894e

Flemmli97 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Dec 19, 2024

phillsatellite added the 🔒 blocked label Dec 19, 2024

phillsatellite added Missing dev review Two dev reviews are required on PR and removed Missing dev review Two dev reviews are required on PR labels Dec 19, 2024

stavares843 approved these changes Dec 20, 2024

View reviewed changes

stavares843 merged commit 623ba64 into dev Dec 20, 2024
11 checks passed

stavares843 deleted the import/export_account branch December 20, 2024 12:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(wasm): Import/export account #893

feat(wasm): Import/export account #893

Flemmli97 commented Nov 27, 2024

github-actions bot commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading

stavares843 left a comment

stavares843 left a comment

This comment was marked as outdated.

Flemmli97 commented Nov 28, 2024 •

edited

Loading

stavares843 commented Nov 28, 2024

dariusc93 left a comment

dariusc93 Dec 11, 2024

Flemmli97 Dec 16, 2024

stavares843 commented Dec 16, 2024

stavares843 commented Dec 16, 2024

phillsatellite commented Dec 19, 2024

feat(wasm): Import/export account #893

feat(wasm): Import/export account #893

Conversation

Flemmli97 commented Nov 27, 2024

What this PR does 📖

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

github-actions bot commented Nov 27, 2024 • edited Loading

github-actions bot commented Nov 27, 2024 • edited Loading

stavares843 left a comment

Choose a reason for hiding this comment

stavares843 left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

Flemmli97 commented Nov 28, 2024 • edited Loading

stavares843 commented Nov 28, 2024

dariusc93 left a comment

Choose a reason for hiding this comment

dariusc93 Dec 11, 2024

Choose a reason for hiding this comment

Flemmli97 Dec 16, 2024

Choose a reason for hiding this comment

stavares843 commented Dec 16, 2024

stavares843 commented Dec 16, 2024

phillsatellite commented Dec 19, 2024

github-actions bot commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading

Flemmli97 commented Nov 28, 2024 •

edited

Loading