Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(community): Add Communities api #935

Merged
merged 7 commits into from
Dec 17, 2024
Merged

feat(community): Add Communities api #935

merged 7 commits into from
Dec 17, 2024

Conversation

Flemmli97
Copy link
Contributor

@Flemmli97 Flemmli97 commented Dec 12, 2024

What this PR does 📖

  • Adds community api calls. No ui elements or anything are implemented. This is just to expose the api to uplinkweb
  • It might warrant future changes since e.g. ConversationStore is also not saving anything atm

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

Download the app installers for this pull request:

Copy link

github-actions bot commented Dec 12, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@phillsatellite
Copy link
Contributor

phillsatellite commented Dec 12, 2024

Hey @Flemmli97 Im noticing something weird with sending attachments in chat

Issue:

  • User A tries to send User B an attachment in chat but attachment will never send. Ive noticed an error that appears in console that Ive attached to this comment

  • Note that this issue does not happen on dev. When I compiled this branch I made sure that I did npm i beforehand as well.

  • User is still able to upload files in the Files page with no issues

Steps to reproduce:

  • Simply add someone either 1on1 or group chat
  • Try to send an attachment

Screenshots & errors:
-This is the error that appears when user attempts to send the attachment
Screenshot 2024-12-12 at 1 53 13 PM

  • Flow
Screen.Recording.2024-12-12.at.1.52.45.PM.mov
  • Dev branch
Screenshot 2024-12-12 at 1 50 30 PM

@phillsatellite phillsatellite added QA Requested Changes Changes need to be addressed, something is not working as expected. and removed Missing dev review Two dev reviews are required on PR labels Dec 12, 2024
@Flemmli97
Copy link
Contributor Author

attachment will be addressed in another PR (caused by some changes on warp)

@Flemmli97 Flemmli97 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Dec 13, 2024
@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Dec 15, 2024
src/lib/wasm/RaygunStore.ts Show resolved Hide resolved
src/lib/wasm/RaygunStore.ts Show resolved Hide resolved
src/lib/wasm/RaygunStore.ts Show resolved Hide resolved
src/lib/wasm/RaygunStore.ts Show resolved Hide resolved
@github-actions github-actions bot removed the Failed Automated Test Failed Automated Tests CI label Dec 16, 2024
@stavares843 stavares843 merged commit 3f76546 into dev Dec 17, 2024
11 checks passed
@stavares843 stavares843 deleted the communities-api branch December 17, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants