feat(friends): Allow quick add friend from link

[Flemmli97]

What this PR does 📖

• Allows one to quickly add someone to friends from a link. The link is of format doman/friends/add/<did> e.g. localhost:5173/friends/add/some_did.
  Opening that link brings you to the friends page with a pop up allowing you to send a friend request to that user
• Currently no in app way to generate the link. Ideas about this?

Which issue(s) this PR fixes 🔨

• Resolve task(Friends): Add a way to share DID  #862

[github-actions]

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

[lgmarchi]

What this PR does 📖

• Allows one to quickly add someone to friends from a link. The link is of format doman/friends/add/<did> e.g. localhost:5173/friends/add/some_did.
  Opening that link brings you to the friends page with a pop up allowing you to send a friend request to that user
• Currently no in app way to generate the link. Ideas about this?

Which issue(s) this PR fixes 🔨

• Resolve task(Friends): Add a way to share DID  #862

I think this can work to generate link and send to others @Flemmli97

  let generatedLink = "";

 function generateLink() {
    generatedLink = `${window.location.origin}/friends/add/${userId}`;
  }

[Flemmli97]

What this PR does 📖

• Allows one to quickly add someone to friends from a link. The link is of format doman/friends/add/<did> e.g. localhost:5173/friends/add/some_did.
  Opening that link brings you to the friends page with a pop up allowing you to send a friend request to that user
• Currently no in app way to generate the link. Ideas about this?

Which issue(s) this PR fixes 🔨

• Resolve task(Friends): Add a way to share DID  #862

I think this can work to generate link and send to others @Flemmli97

  let generatedLink = "";

 function generateLink() {
    generatedLink = `${window.location.origin}/friends/add/${userId}`;
  }

i mean more like where do we want to provide this functionality? when clicking on copy did button e.g.?

[luisecm]

@Flemmli97 Hey Kevin, I noticed that clicking on "Blocked" button from Friends page redirects to the incoming/outgoing requests instead of Blocked List

Grabacion.de.pantalla.2024-12-03.a.la.s.12.08.54.p.m.mov

[luisecm]

@Flemmli97 There is another bug caught by the automation tests - npm run build is failing with the following error:

✓ built in 13.71s

node:internal/event_target:1088
  process.nextTick(() => { throw err; });
                           ^
Error: The following routes were marked as prerenderable, but were not prerendered because they were not found while crawling your app:
  - /friends/add/[user]

See https://svelte.dev/docs/kit/page-options#prerender-troubleshooting for info on how to solve this
    at prerender (file:///Users/luisecm/Satellite/UplinkWeb/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:511:9)
    at async MessagePort.<anonymous> (file:///Users/luisecm/Satellite/UplinkWeb/node_modules/@sveltejs/kit/src/utils/fork.js:23:16)
Emitted 'error' event on Worker instance at:
    at [kOnErrorMessage] (node:internal/worker:326:10)
    at [kOnMessage] (node:internal/worker:337:37)
    at MessagePort.<anonymous> (node:internal/worker:232:57)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:814:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28)

This is the reason why the tauri build jobs for desktop versions are failing on this branch

[lgmarchi]

What this PR does 📖

• Allows one to quickly add someone to friends from a link. The link is of format doman/friends/add/<did> e.g. localhost:5173/friends/add/some_did.
  Opening that link brings you to the friends page with a pop up allowing you to send a friend request to that user
• Currently no in app way to generate the link. Ideas about this?

Which issue(s) this PR fixes 🔨

• Resolve task(Friends): Add a way to share DID  #862

I think this can work to generate link and send to others @Flemmli97

  let generatedLink = "";

 function generateLink() {
    generatedLink = `${window.location.origin}/friends/add/${userId}`;
  }

i mean more like where do we want to provide this functionality? when clicking on copy did button e.g.?

I think would be nice to send in chat for example, the other user just click in add, but would be better, if show pop up, without go out of chats page.

[stavares843]

luis comment needs fixing

[Flemmli97]

What this PR does 📖

• Allows one to quickly add someone to friends from a link. The link is of format doman/friends/add/<did> e.g. localhost:5173/friends/add/some_did.
  Opening that link brings you to the friends page with a pop up allowing you to send a friend request to that user
• Currently no in app way to generate the link. Ideas about this?

Which issue(s) this PR fixes 🔨

• Resolve task(Friends): Add a way to share DID  #862

I think this can work to generate link and send to others @Flemmli97

  let generatedLink = "";

 function generateLink() {
    generatedLink = `${window.location.origin}/friends/add/${userId}`;
  }

i mean more like where do we want to provide this functionality? when clicking on copy did button e.g.?

I think would be nice to send in chat for example, the other user just click in add, but would be better, if show pop up, without go out of chats page.

i think for chat we already have that if you send a did it will autoformat with button to add (if not we had that in native). so link that redirects you to different page dont think is better than that

[Flemmli97]

added a dropdown when right clicking copy did in friend page and profile setting page. it will copy a pasteable url

[github-actions]

Download the app installers for this pull request:

• build-macos.zip
• build-windows.zip
• build-ubuntu.zip
• build-android.zip

[luisecm]

@Flemmli97 Hey Kevin, I noticed that clicking on "Blocked" button from Friends page redirects to the incoming/outgoing requests instead of Blocked List

Grabacion.de.pantalla.2024-12-03.a.la.s.12.08.54.p.m.mov

Hello @Flemmli97 is there any update about this one? Its still failing for me. thanks!

[phillsatellite]

Hey @Flemmli97 so during testing I had an issue

So the link will take me to the app and add modal pops up but it will say "unknown user and unknown status message" and will never seem to load the username. But when I click add the request does go through as expected

[Flemmli97]

Hey @Flemmli97 so during testing I had an issue

So the link will take me to the app and add modal pops up but it will say "unknown user and unknown status message" and will never seem to load the username. But when I click add the request does go through as expected

yes it just fails to fetch the identity from warp. not too sure why though and i wont pin it on this PR. maybe @dariusc93 can shed some light on it?
the identity gets found if the friend request is sent

[dariusc93]

If the user never been discovered before it would attempt discovery upon lookup and would emit an event upon the user being discovered and verified. Not sure if the modal is updating upon the event being emitted either though but it does somewhat make sense on why it goes through since it is happening in the background. If the user been discovered previously by the same account and it is cached but not showing up, i would need more information to see if its a bug in how it is cached.

[Flemmli97]

If the user never been discovered before it would attempt discovery upon lookup and would emit an event upon the user being discovered and verified. Not sure if the modal is updating upon the event being emitted either though but it does somewhat make sense on why it goes through since it is happening in the background. If the user been discovered previously by the same account and it is cached but not showing up, i would need more information to see if its a bug in how it is cached.

If the user never been discovered before it would attempt discovery upon lookup and would emit an event upon the user being discovered and verified. Not sure if the modal is updating upon the event being emitted either though but it does somewhat make sense on why it goes through since it is happening in the background. If the user been discovered previously by the same account and it is cached but not showing up, i would need more information to see if its a bug in how it is cached.

it uses a store which updates when identity is fetched from multipass via Multipass#get_identity
I already verified that Multipass#get_identity fails to fetch an identity if you never interacted with the given user before (e.g. if you friended them and unfriended then it returns correctly).

[Flemmli97]

needs shuttle to find users that are not discovered yet (aka warp/wasm update)

[Flemmli97]

see #893 (review)