Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the dependency for test containers and logging format for console #49

Merged
merged 24 commits into from
Dec 19, 2023

Conversation

vikhyat187
Copy link
Contributor

@vikhyat187 vikhyat187 commented Dec 2, 2023

…le logs

Date: 2nd Dec

Developer Name: @vikhyat187


Issue Ticket Number

Description

This is PR for integration tests of /skills endpoint, and the setup for db in integration tests

Documentation Updated?

  • Yes
  • No

If your feature adds a new API, then documentation related to the feature like API-Contracts, and Data-models must be updated.

Breaking Changes

  • Yes
  • No

If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.

Development Tested?

  • Yes
  • No

Confirm whether the changes have been tested locally during development.

Tested in Staging?

  • Yes
  • No

Indicate whether the changes have been tested in the staging environment.

Under Feature Flag

  • Yes
  • No

Specify if the changes are currently under a feature flag.

Database Changes

  • Yes
  • No

Indicate whether the changes include modifications to the database.

Note to developers

Test Coverage

Integration tests
image

@vikhyat187 vikhyat187 self-assigned this Dec 2, 2023
@vikhyat187 vikhyat187 changed the title [DRAFT] Added the dependency for test containers and logging format for conso… Added the dependency for test containers and logging format for console Dec 7, 2023
@debanjanc01
Copy link
Contributor

debanjanc01 commented Dec 9, 2023

@vikhyat187 I tried checking out this branch on local, but it's unable to find the following

    private final UserService userService;
    private final SkillsService skillsService;
    private UserDTO user;
    private SkillDTO skill;

How are you running this in local without these classes?

@vikhyat187
Copy link
Contributor Author

Hi @debanjanc01 they are two PRs which had to get merged before this one, they are not yet merged, in those PRs we have these classes, so I had to write test in those branch and check its working.

PR for skill service - #34
PR for user service - #22

@vikhyat187
Copy link
Contributor Author

image

debanjanc01
debanjanc01 previously approved these changes Dec 14, 2023
Copy link
Contributor

@heyrandhir heyrandhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we incorporate a test to verify the functionality of pagination. Additionally, I'd like to propose an adjustment in the endpoint structure. It seems that /skills/name/:name might be misleading, considering that name is not the primary resource identifier. I suggest using it as a query parameter instead of part of the path parameter.

@vikhyat187
Copy link
Contributor Author

The name route we discussed in discord earlier if you can remember

@heyrandhir
Copy link
Contributor

Maybe I missed that. Can you please let me know the summary of the discussion.

@vikhyat187
Copy link
Contributor Author

@vikhyat187 vikhyat187 dismissed heyrandhir’s stale review December 17, 2023 11:47

One change for exception handling, I'll take in a seperate ticket, as it might require a lot of changes.

debanjanc01
debanjanc01 previously approved these changes Dec 18, 2023
@vikhyat187 vikhyat187 merged commit 2d73838 into develop Dec 19, 2023
@vikhyat187 vikhyat187 deleted the db-integration-test branch December 19, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup database for integeration tests to run and GitHub actions
6 participants