-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the dependency for test containers and logging format for console #49
Conversation
…e-backend into db-integration-test merge commit
…ad/skill-tree-backend into db-integration-test merge commit .
skill-tree /src/test/java/com/RDS/skilltree/SkillsIntegrationTests.java
Outdated
Show resolved
Hide resolved
skill-tree /src/test/java/com/RDS/skilltree/SkillsIntegrationTests.java
Outdated
Show resolved
Hide resolved
skill-tree /src/test/java/com/RDS/skilltree/SkillsIntegrationTests.java
Outdated
Show resolved
Hide resolved
@vikhyat187 I tried checking out this branch on local, but it's unable to find the following
How are you running this in local without these classes? |
Hi @debanjanc01 they are two PRs which had to get merged before this one, they are not yet merged, in those PRs we have these classes, so I had to write test in those branch and check its working. |
skill-tree /src/test/java/com/RDS/skilltree/SkillsIntegrationTests.java
Outdated
Show resolved
Hide resolved
…e-backend into db-integration-test merge commit .
…ad/skill-tree-backend into db-integration-test merge commit.
skill-tree /src/test/java/com/RDS/skilltree/TestContainerManger.java
Outdated
Show resolved
Hide resolved
skill-tree /src/test/java/com/RDS/skilltree/TestContainerManger.java
Outdated
Show resolved
Hide resolved
skill-tree /src/test/java/com/RDS/skilltree/TestContainerManger.java
Outdated
Show resolved
Hide resolved
skill-tree /src/test/java/com/RDS/skilltree/TestContainerManger.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we incorporate a test to verify the functionality of pagination. Additionally, I'd like to propose an adjustment in the endpoint structure. It seems that /skills/name/:name
might be misleading, considering that name
is not the primary resource identifier. I suggest using it as a query parameter instead of part of the path parameter.
skill-tree /src/test/java/com/RDS/skilltree/SkillsIntegrationTests.java
Outdated
Show resolved
Hide resolved
The name route we discussed in discord earlier if you can remember |
Maybe I missed that. Can you please let me know the summary of the discussion. |
One change for exception handling, I'll take in a seperate ticket, as it might require a lot of changes.
…ad/skill-tree-backend into db-integration-test merge commit
a8dbcde
…le logs
Date:
2nd Dec
Developer Name: @vikhyat187
Issue Ticket Number
Description
This is PR for integration tests of
/skills
endpoint, and the setup for db in integration testsDocumentation Updated?
If your feature adds a new API, then documentation related to the feature like API-Contracts, and Data-models must be updated.
Breaking Changes
If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.
Development Tested?
Confirm whether the changes have been tested locally during development.
Tested in Staging?
Indicate whether the changes have been tested in the staging environment.
Under Feature Flag
Specify if the changes are currently under a feature flag.
Database Changes
Indicate whether the changes include modifications to the database.
Note to developers
Test Coverage
Integration tests