Add Authorisation and integrate sign up for users

[DashDeipayan]

• Build CRUD APIs #21

[iamitprakash]

get() method throws an exception if the CompletableFuture does not complete successfully. This means that if the getRDSUserData() method fails, the entire request will fail.

[vikhyat187]

should we handle this using timeouts? @iamitprakash, so that we don't perform the operation for too long and return TimeoutException in case of service taking higher time?

[vikhyat187]

If there is any exception in making the call to the RDS backend we return an exception.

[iamitprakash]

getRDSUserId() method is that the method does not handle the case where the token is invalid or expired. The Jwts.parser().parseClaimsJws() method will throw a JwtException if the token is invalid or expired. To handle this exception, you should catch it and return a meaningful error message to the caller.

[vikhyat187]

Hi Tejas, we found this exception AuthenticationCredentialsNotFoundException and its being caught in the caller method.

Line Ref : https://github.com/Real-Dev-Squad/skill-tree-backend/pull/22/files#diff-7b979f99e46f3b3a2a373ff1729e27ffd99fe9798276ff9467236026d0c5236fR66

[vikhyat187]

Try refreshing the token here

[iamitprakash]

optimize on below points please

Use a try-with-resources block. The KeyFactory.getInstance() method throws a NoSuchAlgorithmException if the specified algorithm is not supported. To handle this exception, you can use a try-with-resources block. This will ensure that the KeyFactory object is automatically closed, even if an exception is thrown.

Use a catch block to handle specific exceptions. The KeyFactory.generatePublic() method throws an InvalidKeySpecException if the specified key spec is invalid. To handle this exception, you can use a catch block. This will allow you to return a more specific error message to the caller.

Cache the public key. The convertToRSAPublicKey() method is likely to be called multiple times with the same public key string. To improve performance, you can cache the public key so that it does not need to be generated each time.

[vikhyat187]

Use a try-with-resources block. The KeyFactory.getInstance() method throws a NoSuchAlgorithmException if the specified algorithm is not supported. To handle this exception, you can use a try-with-resources block. This will ensure that the KeyFactory object is automatically closed, even if an exception is thrown.

#22 (comment)

Cache the public key. The convertToRSAPublicKey() method is likely to be called multiple times with the same public key string. To improve performance, you can cache the public key so that it does not need to be generated each time.

Tried caching this value, but the values are getting flushed from the ConcurrentHashMap the reason to be debugged.

[vikhyat187]

I tried caching the public key, since this is used in the filter the values were getting refreshed, will once check this

[iamitprakash]

@DashDeipayan please link Test setup ticket here

[iamitprakash]

TEST setup task details #23

[bhtibrewal]

Is the PR tested? if not, please link a follow-up issue ticket for the same in the description
I do see the test setup issue ticket in the comments, but not the follow-up testing one

[vikhyat187]

Here in this code when ever we throw an custom exception, the middleware is catching the exception and returning 401
Access Denied !! Full authentication is required to access this resource

[vikhyat187]

We will require this file for this PR #49