Adding the APIs for /skills route (Skills Entity) #34

vikhyat187 · 2023-11-15T15:34:53Z

Date: 15 November 2023
Developer Name: @vikhyat187

Description:

[DRAFT PR] This PR has the code changes for the APIs on the endpoint /skills

Is Under Feature Flag

Yes
No

Database changes

Yes
No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

Yes - Writing test cases, will push the changes in sometime, had few doubts asked in the group
No

Is Development Tested?

Yes - Have ran the APIs and checked the response, will once add the test cases
No

vikhyat187 · 2023-11-20T00:08:34Z

The integration tests are not yet written as the database for tests is not available, will setup post this and do the changes for integration tests.
#35

skill-tree /src/test/java/com/RDS/skilltree/unit/SkillsServiceTest.java

skill-tree /src/test/java/com/RDS/skilltree/EndorsementsIntegrationTests.java

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillDRO.java

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillDTO.java

skill-tree /src/test/java/com/RDS/skilltree/unit/SkillsServiceTest.java

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillsController.java

Adding the code for storing ENUMs as ENUM in db

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillModel.java

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillsServiceImpl.java

…sults in the tests

debanjanc01

Looks good!

…tree-backend into skills-api merge commit

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillsController.java

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillDTO.java

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillsController.java

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillsServiceImpl.java

…tree-backend into skills-api merge commit .

vikhyat187 · 2023-12-10T08:25:08Z

code coverage is missing, please do necessary arrangements

Hi @iamitprakash now the integration tests are also written for this PR, can you please approve this PR.

Integration tests PR - #49

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillsServiceImpl.java

…d/skill-tree-backend into skills-api" This reverts commit 9074902, reversing changes made to bb4f2ba.

Hi Tejas this stats have been added, so resolving the review comments.

vikhyat187 added 3 commits November 15, 2023 20:55

APIs for '/skills' endpoint

ca5dd65

Remove logs added for debugging purpose

43f2119

Updated the code for GET /skills in paginated form

48bae00

vikhyat187 requested review from heyrandhir and bhtibrewal November 19, 2023 09:53

vikhyat187 self-assigned this Nov 20, 2023

Updated the test for the get paginated skills

cf548bb

vikhyat187 changed the title ~~[DRAFT] Adding the APIs for /skills route (Skills Entity)~~ Adding the APIs for /skills route (Skills Entity) Nov 20, 2023

debanjanc01 reviewed Nov 20, 2023

View reviewed changes

skill-tree /src/test/java/com/RDS/skilltree/unit/SkillsServiceTest.java Outdated Show resolved Hide resolved

debanjanc01 reviewed Nov 20, 2023

View reviewed changes

skill-tree /src/test/java/com/RDS/skilltree/EndorsementsIntegrationTests.java Outdated Show resolved Hide resolved

debanjanc01 reviewed Nov 20, 2023

View reviewed changes

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillDRO.java Outdated Show resolved Hide resolved

debanjanc01 reviewed Nov 20, 2023

View reviewed changes

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillDTO.java Show resolved Hide resolved

vikhyat187 added 2 commits November 20, 2023 22:17

Removing commented code and removing @builder annotation

2ea1f05

Removing the constructor using the builder instead

d64e892

vikhyat187 requested a review from debanjanc01 November 20, 2023 17:04

heyrandhir suggested changes Nov 22, 2023

View reviewed changes

vikhyat187 and others added 4 commits November 23, 2023 05:22

Merge branch 'develop' into skills-api

6cfd9be

Merge branch 'develop' into skills-api

acd229a

Adding the code for storing ENUMs as ENUM in db

Adding error message incase of response not matching expected one

7a56cc8

Merge remote-tracking branch 'upstream/skills-api' into skills-api

6e482a0

debanjanc01 suggested changes Nov 23, 2023

View reviewed changes

vikhyat187 and others added 4 commits November 27, 2023 12:41

Merge branch 'develop' into skills-api

80e1d71

Removing AllArgs and NoArgs constructor and checking the paginated re…

b1cafd0

…sults in the tests

Merge the changes from develop

641d96f

Remove the @DaTa from Skill Model

581a942

vikhyat187 requested a review from heyrandhir November 27, 2023 08:50

Throwing the custom exception incase of skill not found

18bc102

vikhyat187 requested a review from debanjanc01 November 27, 2023 13:32

debanjanc01 previously approved these changes Nov 27, 2023

View reviewed changes

Merge branch 'develop' into skills-api

63cb4af

vikhyat187 requested a review from Ajeyakrishna-k December 5, 2023 16:55

vikhyat187 added 2 commits December 7, 2023 06:53

Wrapping the Response message into a class and returning

34761d7

Merge branch 'skills-api' of https://github.com/Real-Dev-Squad/skill-…

fcadc24

…tree-backend into skills-api merge commit

vikhyat187 mentioned this pull request Dec 7, 2023

Added the dependency for test containers and logging format for console #49

Merged

12 tasks

Ajeyakrishna-k reviewed Dec 7, 2023

View reviewed changes

vikhyat187 and others added 3 commits December 10, 2023 12:48

Merge branch 'develop' into skills-api

8c8d9be

Added the validations on request object using @Valid

bb4f2ba

Merge branch 'skills-api' of https://github.com/Real-Dev-Squad/skill-…

9074902

…tree-backend into skills-api merge commit .

vikhyat187 mentioned this pull request Dec 10, 2023

Try looking into libraries for conversion #56

Closed

vikhyat187 requested a review from Ajeyakrishna-k December 10, 2023 16:03

Ajeyakrishna-k reviewed Dec 12, 2023

View reviewed changes

skill-tree /src/main/java/com/RDS/skilltree/Skill/SkillsServiceImpl.java Outdated Show resolved Hide resolved

Ajeyakrishna-k previously approved these changes Dec 12, 2023

View reviewed changes

vikhyat187 added 2 commits December 12, 2023 08:35

Using the @AllArgs to reduce boilerplatecode

2a4d04b

Revert "Merge branch 'skills-api' of https://github.com/Real-Dev-Squa…

8b759f0

…d/skill-tree-backend into skills-api" This reverts commit 9074902, reversing changes made to bb4f2ba.

vikhyat187 dismissed Ajeyakrishna-k’s stale review via e8c0b22 December 12, 2023 03:11

Removing the constructor and using the AllArgs annotation

e8c0b22

vikhyat187 requested review from heyrandhir and Ajeyakrishna-k December 12, 2023 03:13

heyrandhir previously approved these changes Dec 12, 2023

View reviewed changes

Update with Required Args constructor

5f857f0

vikhyat187 dismissed heyrandhir’s stale review via 5f857f0 December 12, 2023 03:19

vikhyat187 added 2 commits December 12, 2023 08:50

Update with Required Args constructor

997050e

Resolving conflicts

bcc0093

heyrandhir approved these changes Dec 12, 2023

View reviewed changes

Ajeyakrishna-k approved these changes Dec 12, 2023

View reviewed changes

vikhyat187 merged commit 7dd6c33 into develop Dec 12, 2023

vikhyat187 deleted the skills-api branch December 12, 2023 03:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding the APIs for /skills route (Skills Entity) #34

Adding the APIs for /skills route (Skills Entity) #34

vikhyat187 commented Nov 15, 2023

vikhyat187 commented Nov 20, 2023

debanjanc01 left a comment

vikhyat187 commented Dec 10, 2023

Adding the APIs for /skills route (Skills Entity) #34

Adding the APIs for /skills route (Skills Entity) #34

Conversation

vikhyat187 commented Nov 15, 2023

Description:

Is Development Tested?

vikhyat187 commented Nov 20, 2023

debanjanc01 left a comment

Choose a reason for hiding this comment

vikhyat187 commented Dec 10, 2023