-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamixel_general_hw package #390
Open
pazeshun
wants to merge
36
commits into
ROBOTIS-GIT:master
Choose a base branch
from
pazeshun:dynamixel-general-hw
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er present information (temperature, voltage)
…om emergency state
…t related to whether we can get current or load
…coming random if their definition order changes
…namixel to reading Dynamixel for avoiding reading error
… to prevent runaway when going back to normal state
….launch to README
pazeshun
force-pushed
the
dynamixel-general-hw
branch
from
December 13, 2024 17:54
bc433f1
to
bc58352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
dynamixel_workbench_controllers
does not have a follow_joint_trajectory action interface, which is the common interface to move robot joints.In addition, it does not support a reduction between an actuator and a joint.
Those features can be achieved by using ros_control, which is the common controller architecture in ROS (e.g., https://github.com/ROBOTIS-GIT/open_manipulator_controls ).
Previously, we usually write a hardware layer for each robot (
hardware_interface::RobotHW
) usingDynamixelWorkbench
class indynamixel_workbench_toolbox
.Although that layer may include some features unique to each robot, it should also have a common part as long as it uses ros_control and
DynamixelWorkbench
class.This PR extracts that common part and organizes it into
dynamixel_general_hw
package.I think this package can be merged into dynamixel-workbench because this package purely depends on dynamixel-workbench packages and released common packages (e.g., ros_control packages).
Please try samples in https://github.com/pazeshun/dynamixel-workbench/tree/dynamixel-general-hw/dynamixel_general_hw#samples.