[MIG] account_invoice_base_invoicing_mode: Migration to 15.0 #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add three modules helping on automatically invoicing customers. The base module `account_invoice_base_invoicing_mode` does not actually do anything but adds a selection field on partner to allow assigning an invoicing mode to a customer. And a checkbox to choose regrouping invoices. The two other modules add specific invoicing mode. The module `account_invoice_mode_monthly` creates monthly invoices for customer on a specific day (configuration is in Accounting Settings) The module `account_invoice_mode_at_shipping` creates invoices on the shipping of the goods. Those modules use queue_job to generate and validate invoices.
Add few changes from reviews. Use sudo to post the invoice.
Split invoice creation on invoice partner settings that decides if sales order atre being grouped in invoice or not. The previous implementation would crash.
ajaniszewska-dev
approved these changes
Feb 18, 2022
1 task
|
/ocabot migration account_invoice_base_invoicing_mode |
|
Administrative commit should be squash see https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0 |
…one_invoice_per_order' to res.partner's _commercial_fields()
rven
force-pushed
the
15.0-mig-account_invoice_base_invoicing_mode
branch
from
b24d036
to
528b90f
Compare
Comment on lines
+3
to
+7
| * account_invoice_base_invoicing_mode -> partner_invoicing_mode | ||
| * account_invoice_mode_monthly -> partner_invoicing_mode_monthly | ||
| * account_invoice_mode_at_shipping -> partner_invoicing_mode_at_shipping | ||
|
|
||
| It would be great to do it, during the version 15.0 migration. |
| class SaleOrder(models.Model): | ||
| _inherit = "sale.order" | ||
|
|
||
| invoicing_mode = fields.Selection(related="partner_invoice_id.invoicing_mode") |
There was a problem hiding this comment.
this field probably should be computed to consider the state of sale.order
if we have one invoicing_mode, sold stuff confirm pay deliver, and then change mode on partner then mode on sale order also will change
thou this is a theoretical assumption, it could be that method implemented to avoid these issue
|
CI is red, could you check please? 🙏🏻 |
|
Closing in favour of #1243. I now based the 16.0 migration of the module on that PR. I hope that's alright! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.