-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] account_invoice_mode_at_shipping: Migration to 15.0 #1101
[MIG] account_invoice_mode_at_shipping: Migration to 15.0 #1101
Conversation
Add three modules helping on automatically invoicing customers. The base module `account_invoice_base_invoicing_mode` does not actually do anything but adds a selection field on partner to allow assigning an invoicing mode to a customer. And a checkbox to choose regrouping invoices. The two other modules add specific invoicing mode. The module `account_invoice_mode_monthly` creates monthly invoices for customer on a specific day (configuration is in Accounting Settings) The module `account_invoice_mode_at_shipping` creates invoices on the shipping of the goods. Those modules use queue_job to generate and validate invoices.
If we group several sales in the same procurement group, we'll invoice only one sale order. Tracing back to the sales through the stock moves ensure we invoice all of them.
Through the stock moves
Add few changes from reviews. Use sudo to post the invoice.
Split invoice creation on invoice partner settings that decides if sales order atre being grouped in invoice or not. The previous implementation would crash.
Filter out sales order that have nothing to invoice. To avoid an exception at invoice createion.
Add explicit message if nothing is invoiced
@BertVGroenendael can you please fix build? |
@ajaniszewska-dev This build cannot be fixed at this moment because it depends on account_invoice_base_invoicing_mode which is also in PR #1061 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LG, for dependency OCA PRs you may use test-requirements.txt to refer them for test/build purpose.
|
yes, however afair there is no test-requirements specified in this doc (i don't know why). How it was worked for me, to add in separate commit test-requirements.txt file with content inside:
plus worth add note in PR description that it depends on PR (PR number) and dependency file was updated in the separate commit. |
This module depends on #1061. |
b17e13d
to
05a866b
Compare
Closing in favour of #1247. I have now based the 16.0 migration of the module on that PR. Thank you nevertheless for your contribution! |
No description provided.