[15.0][MIG] account_invoice_base_invoicing_mode (renamed) #1243

TDu · 2022-09-26T08:36:01Z

Renamed to partner_invoicing_mode.

Add three modules helping on automatically invoicing customers. The base module `account_invoice_base_invoicing_mode` does not actually do anything but adds a selection field on partner to allow assigning an invoicing mode to a customer. And a checkbox to choose regrouping invoices. The two other modules add specific invoicing mode. The module `account_invoice_mode_monthly` creates monthly invoices for customer on a specific day (configuration is in Accounting Settings) The module `account_invoice_mode_at_shipping` creates invoices on the shipping of the goods. Those modules use queue_job to generate and validate invoices.

Add few changes from reviews. Use sudo to post the invoice.

Split invoice creation on invoice partner settings that decides if sales order atre being grouped in invoice or not. The previous implementation would crash.

…one_invoice_per_order' to res.partner's _commercial_fields()

i-vyshnevska

LG, in the context of renaming should we suggest a migration step to handle XML updates?

TDu · 2022-09-30T12:55:05Z

I just added the migration script for the module rename

StefanRijnhart

I don't think that the renaming works in the migration of module itself. The renaming has to be done here: https://github.com/OCA/OpenUpgrade/blob/15.0/openupgrade_scripts/apriori.py#L6

TDu · 2022-10-17T06:58:45Z

I don't think that the renaming works in the migration of module itself. The renaming has to be done here: https://github.com/OCA/OpenUpgrade/blob/15.0/openupgrade_scripts/apriori.py#L6

Ok, I based that on existing commit in other repos. Do you mean I have to open a PR on openupgrade ?

StefanRijnhart · 2022-10-17T09:02:34Z

Yes please! In that PR, please link to this PR so that we can merge in tandem.

StefanRijnhart · 2022-11-18T13:20:26Z

@TDu please remove that migration bit in this PR, then we can go ahead with it.

rafaelbn · 2022-12-09T19:20:04Z

/ocabot migration account_invoice_base_invoicing_mode

OCA-git-bot · 2022-12-09T19:20:15Z

The migration issue (#1022) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1061.
Perhaps you should check that there is no duplicate work.
CC : @rven

TDu · 2022-12-12T08:37:34Z

I removed the migration script

rafaelbn · 2022-12-13T17:35:40Z

@simahawk ? you merged it in v13 😄 #755

houssine78 · 2023-04-18T15:42:32Z

@pedrobaeza this PR is ready to be merge :) Thanks

pedrobaeza · 2023-04-18T15:52:06Z

Merging blindly due to the reviews:

/ocabot merge nobump

OCA-git-bot · 2023-04-18T15:52:42Z

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1243-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-04-18T16:05:40Z

Congratulations, your PR was merged at 3b61454. Thanks a lot for contributing to OCA. ❤️

Signed-off-by AaronHForgeFlow

TDu mentioned this pull request Sep 26, 2022

[MIG] account_invoice_base_invoicing_mode: Migration to 15.0 #1061

Closed

TDu and others added 12 commits September 27, 2022 13:49

[13.0][FIX] Add acconut_invoicing_mode

bb97bc6

Add few changes from reviews. Use sudo to post the invoice.

[13.0][FIX] account_invoicing_mode_at_shipping

84a3f9e

Split invoice creation on invoice partner settings that decides if sales order atre being grouped in invoice or not. The previous implementation would crash.

[13.0] account-invoicing-mode add roadmap

92f9740

[MIG] account_invoice_mode: Migration to 14.0

7927fc8

account_invoice_base_invoicing_mode: update roadmap for v15 [ci skip]

4f13f45

[UPD] Update account_invoice_base_invoicing_mode.pot

f9488c9

[UPD] README.rst

e0e7c39

[FIX] account_invoice_base_invoicing_mode: Add 'invoicing_mode' and '…

b4970e6

…one_invoice_per_order' to res.partner's _commercial_fields()

account_invoice_base_invoicing_mode 14.0.1.1.0

33aedd0

[IMP] account_invoice_base_invoicing_mode: black, isort, prettier

115a720

[MIG] account_invoice_base_invoicing_mode: Migration to 15.0

c0264ea

TDu force-pushed the 15-mig-base-invoicing-mode branch 2 times, most recently from 6e04ef3 to eb95d9d Compare September 27, 2022 13:48

i-vyshnevska approved these changes Sep 28, 2022

View reviewed changes

This was referenced Sep 29, 2022

[MIG][15.0] account_invoicing_mode_at_shipping (renamed) #1247

Merged

[15.0][MIG] account_invoice_mode_monthly (renamed) #1245

Closed

StefanRijnhart approved these changes Sep 29, 2022

View reviewed changes

OCA-git-bot added the approved label Sep 29, 2022

TDu force-pushed the 15-mig-base-invoicing-mode branch from eb95d9d to 0bb9a23 Compare September 30, 2022 12:54

TDu force-pushed the 15-mig-base-invoicing-mode branch from 0bb9a23 to 68c66cd Compare September 30, 2022 13:02

StefanRijnhart requested changes Oct 1, 2022

View reviewed changes

OCA-git-bot removed the approved label Oct 1, 2022

StefanRijnhart mentioned this pull request Nov 30, 2022

[MIG] partner_invoicing_mode, partner_invoicing_mode_at_shipping, partner_invoicing_mode_monthly: Migration to 16.0 #1295

Merged

OCA-git-bot added this to the 15.0 milestone Dec 9, 2022

OCA-git-bot mentioned this pull request Dec 9, 2022

Migration to version 15.0 #1022

Open

56 tasks

[MIG] rename account_invoice_base_invoicing_mode

7e64d17

TDu force-pushed the 15-mig-base-invoicing-mode branch from 68c66cd to 7e64d17 Compare December 12, 2022 08:37

StefanRijnhart approved these changes Dec 12, 2022

View reviewed changes

OCA-git-bot added the approved label Dec 12, 2022

houssine78 approved these changes Apr 18, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Apr 18, 2023

OCA-git-bot merged commit d083a99 into OCA:15.0 Apr 18, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 18, 2023

odooNextev pushed a commit to odooNextev/account-invoicing that referenced this pull request Sep 29, 2023

Merge PR OCA#1243 into 14.0

6bc59d7

Signed-off-by AaronHForgeFlow

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] account_invoice_base_invoicing_mode (renamed) #1243

[15.0][MIG] account_invoice_base_invoicing_mode (renamed) #1243

TDu commented Sep 26, 2022 •

edited by StefanRijnhart

Loading

i-vyshnevska left a comment

TDu commented Sep 30, 2022

StefanRijnhart left a comment

TDu commented Oct 17, 2022

StefanRijnhart commented Oct 17, 2022

StefanRijnhart commented Nov 18, 2022

rafaelbn commented Dec 9, 2022

OCA-git-bot commented Dec 9, 2022

TDu commented Dec 12, 2022

rafaelbn commented Dec 13, 2022

houssine78 commented Apr 18, 2023

pedrobaeza commented Apr 18, 2023

OCA-git-bot commented Apr 18, 2023

OCA-git-bot commented Apr 18, 2023

[15.0][MIG] account_invoice_base_invoicing_mode (renamed) #1243

[15.0][MIG] account_invoice_base_invoicing_mode (renamed) #1243

Conversation

TDu commented Sep 26, 2022 • edited by StefanRijnhart Loading

i-vyshnevska left a comment

Choose a reason for hiding this comment

TDu commented Sep 30, 2022

StefanRijnhart left a comment

Choose a reason for hiding this comment

TDu commented Oct 17, 2022

StefanRijnhart commented Oct 17, 2022

StefanRijnhart commented Nov 18, 2022

rafaelbn commented Dec 9, 2022

OCA-git-bot commented Dec 9, 2022

TDu commented Dec 12, 2022

rafaelbn commented Dec 13, 2022

houssine78 commented Apr 18, 2023

pedrobaeza commented Apr 18, 2023

OCA-git-bot commented Apr 18, 2023

OCA-git-bot commented Apr 18, 2023

TDu commented Sep 26, 2022 •

edited by StefanRijnhart

Loading