Create transactions resource

[DXRovang]

Dev Summary

adding the transactions resource here. this is a key part of our data model. this is how users will claim/give assets.
this includes the standard parts of a new resource (controller, service, module, entity, dtos, etc.)

Test Plan

repro steps:

1. npm run start:dev
2. seed some data if you need

curl -X POST localhost:3001/api/users \
-H "Content-Type: application/json" \
-d '{ "first_name": "test", "last_name": "user", "password": "password", "email": "[email protected]" }'

curl -X POST localhost:3001/api/users \
-H "Content-Type: application/json" \
-d '{ "first_name": "test", "last_name": "user2", "password": "password", "email": "[email protected]" }'

# except below should have the id that one of the user create requests returned
curl -X POST localhost:3001/api/assets \
-H "Content-Type: application/json" \
-d '{ "title": "thing 1", "description": "its a thing", "type": "donation", "quantity": "1",
"poster": { "first_name":"test", "last_name":"user", "email":"[email protected]", "id": "18" } }'

curl -X POST localhost:3001/api/organizations \
-H "Content-Type: application/json" -d '{
  "name": "name",
  "description": "description",
  "website": "website.com",
  "address": "address",
  "phone": "phone",
  "city": "seattle",
  "state": "wa",
  "ein": "1",
  "tax_exempt_id": "1"
}'

3. create transaction

# below should use the other created user's id
jamesrogers@jamesrogpremiseMBP-2 web-app % curl -X POST localhost:3001/api/transactions \
-H "Content-Type: application/json" -d '{ "donater_user": "19", "asset": "1" }'
{"donater_user":"19","asset":"1","id":3,"status":"IN_PROGRESS","created_date":"2022-01-22"}%      
jamesrogers@jamesrogpremiseMBP-2 web-app % 

4. update transaction status and with recipient org

jamesrogers@jamesrogpremiseMBP-2 web-app % curl -X PATCH localhost:3001/api/transactions/3 \
-H "Content-Type: application/json" -d '{ "status": "COMPLETED", "recipient": "1"}' 
{"id":3,"status":"COMPLETED","created_date":"2022-01-22","asset":{"id":1,"title":"thing 1","description":"its a thing","type":"donation","condition":"","quantity":1},"recipient":"1"}%             
jamesrogers@jamesrogpremiseMBP-2 web-app % 

5. get all transactions
   expect there to be one

jamesrogers@jamesrogpremiseMBP-2 web-app % curl localhost:3001/api/transactions 
[{"id":3,"status":"COMPLETED","created_date":"2022-01-22","asset":{"id":1,"title":"thing 1","description":"its a thing","type":"donation","condition":"","

6. delete the transaction
   then get all transactions again and expect it to be empty

jamesrogers@jamesrogpremiseMBP-2 web-app % curl -X DELETE localhost:3001/api/transactions/3
jamesrogers@jamesrogpremiseMBP-2 web-app % curl localhost:3001/api/transactions            
[]%       

Resources

• https://typeorm.io/#/eager-and-lazy-relations
• https://docs.nestjs.com/techniques/database#custom-repository
• https://typeorm.io/#/custom-repository
• https://docs.nestjs.com/techniques/validation
• https://github.com/typestack/class-validator

[esteban-gs]

Fix:

Should be:

 @IsNotEmpty()
  donater_user_id: number;

[jd2rogers2]

hmmm, are you sure?
would nest know to add a .donater attr or function to the transation model then? now that i think about it, idk how to control the model in nest, like if i wanted to write a custom function like asset.close() (that updates the status to all the transactions related to that asset, how would i do that?

[esteban-gs]

Looking at your example,

This:

curl -X POST localhost:3001/api/assets \
-H "Content-Type: application/json" \
-d '{ "title": "thing 1", "description": "its a thing", "type": "donation", "quantity": "1",
"poster": { "first_name":"test", "last_name":"user", "email":"[email protected]", "id": "18" } }'

can be replaced by example below, if you change the createDto to use poster_id instead of a whole new poster object. The return type will be whatever the repository returns (transactionEntity):

curl -X POST localhost:3001/api/assets \
-H "Content-Type: application/json" \
-d '{ "title": "thing 1", "description": "its a thing", "type": "donation", "quantity": "1",
"poster_id": 18 }'

[esteban-gs]

Then, you would have to implement something like: create-transactions-resource...sample/create-transactions-resource

Also, if you are going to stick with the getTransactionsDto as the get all filtering model, there is some funky formatting we have to do in the front end to send the nested object in the url query params. See this

[esteban-gs]

Fix:

Should be:

 @IsNotEmpty()
  donater_organization_id: number;

[esteban-gs]

Same as above, only the foreign key is required

[esteban-gs]

Same as above, only the foreign key is required

[esteban-gs]

See comments

[esteban-gs]

Don't these cancel each other?

[jd2rogers2]

totally 😆
removed altogether because the default value should be used and so we don't need to pass anything in