Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTO and other clean up #137

Merged
merged 7 commits into from
Mar 22, 2022
Merged

DTO and other clean up #137

merged 7 commits into from
Mar 22, 2022

Conversation

jd2rogers2
Copy link
Contributor

@jd2rogers2 jd2rogers2 commented Jan 30, 2022 •
edited
Loading

Dev Summary

see linked issue

Test Plan

repro steps:

  1. npm run start:dev
  2. maybe follow test plan from Create transactions resource #92
    (had a good test plan that included a lot of BE hits that included creating relationships throughout a lot of our data model)

Resources

@jd2rogers2 jd2rogers2 linked an issue Feb 2, 2022 that may be closed by this pull request
audit all DTOs to use appropriate helpers #73
Closed
@jd2rogers2 jd2rogers2 changed the title WIP clean up DTO and other clean up Feb 20, 2022
@jd2rogers2 jd2rogers2 marked this pull request as ready for review February 20, 2022 21:18
@jd2rogers2 jd2rogers2 linked an issue Mar 1, 2022 that may be closed by this pull request
add create user validation #129
Closed
esteban-gs
esteban-gs requested changes Mar 20, 2022
View reviewed changes
Copy link
Contributor

@esteban-gs esteban-gs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments and resolve conflicts

@jd2rogers2 jd2rogers2 requested a review from esteban-gs March 20, 2022 16:34
@jd2rogers2
Copy link
Contributor Author

See comments and resolve conflicts

conflicts resolved, and put a ticket in for the comments
ready for another look here

@jd2rogers2 jd2rogers2 merged commit 7656338 into main Mar 22, 2022
@jd2rogers2 jd2rogers2 deleted the jrogers/cleanup branch March 22, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esteban-gs esteban-gs esteban-gs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add create user validation audit all DTOs to use appropriate helpers
2 participants
@jd2rogers2 @esteban-gs