Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discovery: sanitize dtos to entities before repository write #136

Open
1 of 3 tasks
jd2rogers2 opened this issue Jan 29, 2022 · 0 comments · Fixed by #373
Open
1 of 3 tasks

discovery: sanitize dtos to entities before repository write #136

jd2rogers2 opened this issue Jan 29, 2022 · 0 comments · Fixed by #373

Comments

@jd2rogers2
Copy link
Contributor

jd2rogers2 commented Jan 29, 2022

This ticket may simply require making sure that the data returned by back end doesn't return sensitive data like passwords, etc.

reference -> #92 (comment)

https://automapperts.netlify.app/docs/introduction/what-why/
needs a bit of research
not sure i see the downside of writing the DTO object (which already has it's shape enforced by the DTO (used at runtime))
but worth a look

if so clean up of all services needed

Acceptance criteria:

  • Scope limited to account controller
  • password and/or other sensitive data is not returned in results
  • controller should return an instance of a dto class. You could approach this by using the automation that class-transformer provides in this example https://salwoch.hashnode.dev/how-to-serialize-responses-in-nestjs . If you go in this route, use the existing returnDtos instead of the entities
  • Endpoints:
    • Register
    • Get user
    • Profile
@esteban-gs esteban-gs added this to the Clean up before beta milestone Nov 2, 2022
@esteban-gs esteban-gs self-assigned this Sep 10, 2023
@esteban-gs esteban-gs linked a pull request Sep 12, 2023 that will close this issue
@esteban-gs esteban-gs reopened this Sep 16, 2023
@esteban-gs esteban-gs removed their assignment Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants