Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make requestorID and nodeName immutable #15

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

adrianchiris
Copy link
Collaborator

@adrianchiris adrianchiris commented Aug 25, 2024

Add CEL validation rule to make NodeMaintenance RequestorID and NodeName immutable.

Add CEL validation rule to make NodeMaintenance RequestorID
immutable.

Signed-off-by: adrianc <[email protected]>
@coveralls
Copy link

coveralls commented Aug 25, 2024

Pull Request Test Coverage Report for Build 10547916115

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.796%

Totals Coverage Status
Change from base Build 10511482808: 0.0%
Covered Lines: 1008
Relevant Lines: 1532

💛 - Coveralls

Add CEL validation rule to make NodeMaintenance NodeName
immutable.

Signed-off-by: adrianc <[email protected]>
@adrianchiris adrianchiris changed the title make requestorID immutable make requestorID and nodeName immutable Aug 25, 2024
@adrianchiris adrianchiris force-pushed the make-requestor-id-immutable branch from 777d06f to 5a15165 Compare August 25, 2024 14:59
Copy link
Collaborator

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykulazhenkov ykulazhenkov merged commit 9034e67 into Mellanox:main Aug 27, 2024
8 checks passed
@adrianchiris adrianchiris deleted the make-requestor-id-immutable branch January 9, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants