make NodeName immutable

Add CEL validation rule to make NodeMaintenance NodeName immutable. Signed-off-by: adrianc <[email protected]>
Mellanox · Aug 25, 2024 · 777d06f · 777d06f
1 parent 506806f
commit 777d06f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/api/v1alpha1/nodemaintenance_types.go b/api/v1alpha1/nodemaintenance_types.go
@@ -76,6 +76,7 @@ type NodeMaintenanceSpec struct {
 
 	// NodeName is The name of the node that maintenance operation will be performed on
 	// creation fails if node obj does not exist (webhook)
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	NodeName string `json:"nodeName"`
 
 	// Cordon if set, marks node as unschedulable during maintenance operation

diff --git a/api/v1alpha1/zz_generated.deepcopy.go b/api/v1alpha1/zz_generated.deepcopy.go
diff --git a/config/crd/bases/maintenance.nvidia.com_nodemaintenances.yaml b/config/crd/bases/maintenance.nvidia.com_nodemaintenances.yaml
@@ -116,6 +116,9 @@ spec:
                   NodeName is The name of the node that maintenance operation will be performed on
                   creation fails if node obj does not exist (webhook)
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable
+                  rule: self == oldSelf
               requestorID:
                 description: |-
                   RequestorID MUST follow domain name notation format (https://tools.ietf.org/html/rfc1035#section-2.3.1)