Merge pull request #15 from adrianchiris/make-requestor-id-immutable

make requestorID and nodeName immutable

api/v1alpha1/nodemaintenance_types.go

@@ -64,6 +64,7 @@ type NodeMaintenanceSpec struct {
 	// +kubebuilder:validation:Pattern=`^([a-z0-9A-Z]([-a-z0-9A-Z]*[a-z0-9A-Z])?(\.[a-z0-9A-Z]([-a-z0-9A-Z]*[a-z0-9A-Z])?)*)$`
 	// +kubebuilder:validation:MaxLength=63
 	// +kubebuilder:validation:MinLength=2
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	RequestorID string `json:"requestorID"`
 
 	// AdditionalRequestors is a set of additional requestor IDs which are using the same NodeMaintenance
@@ -75,6 +76,7 @@ type NodeMaintenanceSpec struct {
 
 	// NodeName is The name of the node that maintenance operation will be performed on
 	// creation fails if node obj does not exist (webhook)
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	NodeName string `json:"nodeName"`
 
 	// Cordon if set, marks node as unschedulable during maintenance operation

config/crd/bases/maintenance.nvidia.com_nodemaintenances.yaml

@@ -116,6 +116,9 @@ spec:
                   NodeName is The name of the node that maintenance operation will be performed on
                   creation fails if node obj does not exist (webhook)
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable
+                  rule: self == oldSelf
               requestorID:
                 description: |-
                   RequestorID MUST follow domain name notation format (https://tools.ietf.org/html/rfc1035#section-2.3.1)
@@ -127,6 +130,9 @@ spec:
                 minLength: 2
                 pattern: ^([a-z0-9A-Z]([-a-z0-9A-Z]*[a-z0-9A-Z])?(\.[a-z0-9A-Z]([-a-z0-9A-Z]*[a-z0-9A-Z])?)*)$
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable
+                  rule: self == oldSelf
               waitForPodCompletion:
                 description: |-
                   WaitForPodCompletion specifies pods via selector to wait for completion before performing drain operation