feat(match2): Handle submatch/subgroup on hearthstone #5217
+269
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
reviewed
Dec 16, 2024
components/match2/wikis/hearthstone/match_group_util_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/hearthstone/match_group_util_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/hearthstone/match_group_util_custom.lua
Outdated
Show resolved
Hide resolved
| scores[opponentIndex] = 0 | ||
| end | ||
| for _, game in pairs(games) do | ||
| if game.map and String.startsWith(game.map, 'Submatch') and not game.resultType then |
hjpalpha
reviewed
Dec 17, 2024
components/match2/wikis/hearthstone/match_group_util_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/hearthstone/match_group_util_custom.lua
Outdated
Show resolved
Hide resolved
hjpalpha
reviewed
Dec 18, 2024
components/match2/wikis/hearthstone/match_group_util_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/hearthstone/match_group_util_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/hearthstone/match_group_util_custom.lua
Outdated
Show resolved
Hide resolved
Co-authored-by: hjpalpha <[email protected]>
|
So if |
|
imo wait for #5228 so we can make use of it here so we do not have to construct submatches in a way that mirror deprecated stuff but instead the new stuff |
hjpalpha
reviewed
Dec 21, 2024
components/match2/wikis/hearthstone/match_group_util_custom.lua
Outdated
Show resolved
Hide resolved
|
5228 is merged |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Submatch implementations is a copy from Stormgate/Starcraft
How did you test this change?
/dev and sandbox