Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(various): remove usage of deprecated match2 and match2game fields #5229

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

feat(various): remove usage of deprecated match2 and match2game fields #5229

wants to merge 20 commits into from

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Dec 21, 2024 •
edited
Loading

Summary

remove usage of deprecated match2 and match2game fields

  • .resulttype
  • .participants (game)
  • .scores (game)
  • .walkover

Remarks

  • don't have a solution for the query conditions ([[walkover::]]) in sc and sc2 player infoboxes yet
  • ignores hearthstone in fav. of feat(match2): Handle submatch/subgroup on hearthstone #5217
  • need to update non-git usage too --> need decision about the helper module first!
  • there could be some legacy storage modules that rely on walkover being set but don't adjust it in the code, no easy way to track that though

How did you test this change?

tests on 5 wikis + contributor tests

@hjpalpha hjpalpha added the chore label Dec 21, 2024
hjpalpha
hjpalpha commented Dec 21, 2024
View reviewed changes
components/match2/commons/match_opponent_helper.lua
@@ -0,0 +1,34 @@
---
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should i move it into Module:Opponent instead? or somehwere else???

@hjpalpha hjpalpha changed the title feat(various): remove some resulttype usage feat(various): remove resulttype usage Dec 21, 2024
hjpalpha
hjpalpha commented Dec 22, 2024
View reviewed changes
Copy link
Collaborator Author

@hjpalpha hjpalpha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: check if gameOpponents need to be parsed from stringified json to lua table in some of the legacy ones

@hjpalpha hjpalpha changed the title feat(various): remove resulttype usage feat(various): remove "some" usage of deprecated match2 and match2game fields Dec 23, 2024
@hjpalpha hjpalpha added c: infobox c: match2 c: match_table Match Table for on /Matches pages or "Recent Matches" sections labels Dec 23, 2024
@hjpalpha hjpalpha linked an issue Dec 23, 2024 that may be closed by this pull request
Replacement of "resulttype" and "walkover" Properties in Match2 and Match2Game #4821
Open
@hjpalpha hjpalpha changed the title feat(various): remove "some" usage of deprecated match2 and match2game fields feat(various): remove usage of deprecated match2 and match2game fields Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: infobox c: match_table Match Table for on /Matches pages or "Recent Matches" sections c: match2 chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replacement of "resulttype" and "walkover" Properties in Match2 and Match2Game
1 participant
@hjpalpha