Updated scenarios #1025
Merged
Updated scenarios #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…primarily excel).
…the influence of external settings on the appearance of the AB
…he location at which these settings are now applied (at the base application level)
…es in the scenario difference file, with a popup to provide the ability to relink to a database currently loaded within the AB. Error messages are thrown if an activity cannot be relinked, usable for both technosphere and biopshere activities/flows. The search routine is labelled for updating on refactoring for bw2.5.
Improved structure of loading, fixes use of Exceptions for scenario parameter imports.
…on importing a scenario file. Addition of a save functionality for the combined scenario dataframes within the AB.
…s in the scenario files. Improves the messaging and text provided in the popup and warning messages. Enables customisation of default buttons in ABPopups (for GUI error messaging) Added comments and documentation to the recent updated code for checking and processing scenario files.
…ario files. Includes: utilization of the AB-metadata store, progress indication and list comprehension based iteration.
…ases within a scenario file
…function and the ABPopup save_dataframe method: 1) Iterates only through those exchanges containing an unidentifiable database. 2) Corrects the dataseries value assignment in the internal function. 3) The separator for csv files is specified to ';'.
…ases function. 1) Passes the dataframe index to the internal function, allowing the user to save only those exchanges that cannot be linked. 2) Adds a new error to allow the AB to catch the issue and return the cursor to normal.
…and use of bad keys for accessing activities from the BW SQL databases. Part of this work involves the separation of providing the keys and running checks on the keys. If a key is not present and the metadata is correct an error is thrown, this is only dependent on the absence of a single key. The checks have also been moved to execute within the context of the sync_superstructure method of the ScenarioImportWidget class.
…ncluding throwing a more specific error that should be handled softly.
…es for importing scenario difference files. Standardises systems to resolve issues found with input files.
…ions in pandas documentation. Also restores the cursor for use in the appropriate popup windows.
…han QMessageBox). Additional icons are provided.
…tention of the loading cursor symbol. Additional fix for the use of single scenario files with self referential flows.
…olumns by a combinatorial approach.
…ill be incorporated in the LCA analysis
…es function contained a redundant reference to the relinkiing object
…n importing scenario files.
…s and the associated errors.
…r unique scenario names, when combining scenarios across files using a combinatoric approach. Adds popup windows for Errors and warnings related to the scenario names for the 'Extension' approach, for combining scenario files. Changes the location of checks for scenario exchange amounts to the superstructure.manager module and removes the superstructure.exchanges module. Provides some minor editing to messages for popup windows. Combines the updates to calculation procedures to keep aligned with recent merges.
…olumnsWarning'. Contains significant changes to the manager module: Changes the execution of checking the scenario exchange values. Changes the use of scenario expansion errors. Vectorizes the approach used in merge_flows_to_self. Also contains changes to the updated routines for updating scenario calculations.
Zoophobus
added
bug
This was referenced Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds features for sanity checks on scenario difference file imports. Provides multiple new testing features to help in resolving the following issues:
#861 #839 #820 #769 #746 #744 #736 #592 #562 #542 #481
Checklist
bug,feature,ui,change,documentation,breaking,cias they show up in the changelog