Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the "default scenario column" changes LCA results considerably #592

Closed
CHarpprecht opened this issue Apr 27, 2021 · 5 comments
Closed
Labels
bug Issues/PRs related to bugs

Comments

@CHarpprecht
Copy link

Hi there,

if I run the same LCA setups with the same scenario parameters I get different results depending on whether the default column has been added or not. The results differ for the default values and all scenarios. The difference is not negligible, see screenshots:
grafik
grafik

I think that the results without the default columns are wrong, since in my older AB development version, which does not have this feature of the default column yet, I get the same results as for the newer AB version with the default column.
Plus, the results for "default" are the same as for a standard LCA without any scenarios.

This happened in the newest AB development version (2021.04.21) but also in an older one from 2021.04.06.

@ugjav
Copy link

ugjav commented Sep 24, 2021

Hi all,

I face a similar issue regarding scenario-based LCA, detailed below:

I compare a non-parameterized reference flow with the exact same reference flow but parameterized (i.e. parameters are chosen in order that the same reference flow values appear for both).

Accordingly, running a standard LCA, i have the same results for both parameterized and non-parameterized scenario:
image

However, if i run a scenario-based LCA (only one scenario with default values as in standard LCA), I achieve different results between the parameterized and non-parameterized reference flows!
image

No matter which order or name I give to the scenario, i still have this difference that should not exist, and I do not know which result to chose!
Thank you for reconsidering this issue,
Wish you all a good week-end!

@ljlazar
Copy link

ljlazar commented Feb 15, 2022

Hi @ugjav,
I had the same issue occuring once in a while and I was not able to identify the cause yet. However, in my case it is usually fixable by duplicating the affected activity. If you run a scenario LCA with the duplicated activity the results will be the same compared to the standard LCA. Hope this helps a bit!

@bsteubing
Copy link
Member

@CHarpprecht, @ugjav and @ljlazar sorry for replying so late on this. I don't follow your cases 100% to be honest. e.g.

  • @ugjav your results are not equal also in the upper figure.
  • @ljlazar : careful, when you are duplicating an activity, you loose its parameterization (if it was parameterized); i.e. a duplicated activity will contain the parameter names, but it will not actually have these parameters; this is still a shortcoming of the entire parameter implementation in bw and AB

@CHarpprecht : is there any way that you could find out which of the cases produces the correct results (with the default column or without)? (if this still persists...)

@CHarpprecht
Copy link
Author

@bsteubing :
I think that the results without the default columns are wrong, since in my older AB development version, which does not have this feature of the default column yet, I get the same results as for the newer AB version with the default column.
Plus, the results for "default" are the same as for a standard LCA without any scenarios. (this is just a quote from the initial issue, I have not looked into it again)

@Zoophobus Zoophobus mentioned this issue Aug 30, 2023
3 tasks
@marc-vdm
Copy link
Member

Closing this as resolved in #1025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

No branches or pull requests

6 participants