Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(proxy): use more reasonable keepalive default value for Nginx tuning #12223

Merged
merged 2 commits into from
Dec 21, 2023
Merged

perf(proxy): use more reasonable keepalive default value for Nginx tuning #12223

merged 2 commits into from
Dec 21, 2023

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Dec 19, 2023 •
edited
Loading

Summary

Bumped default values of nginx_http_keepalive_requests and upstream_keepalive_max_requests to 10000.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-3360

@chobits
Copy link
Contributor Author

chobits commented Dec 19, 2023

do not merge until we have accomplished the performance test of these values.

@bungle
Copy link
Member

bungle commented Dec 19, 2023

perf(template) is wrong perf(proxy) or perf(core) is better.

@chobits
Copy link
Contributor Author

chobits commented Dec 20, 2023

perf(template) is wrong perf(proxy) or perf(core) is better.

Thx, @bungle will use perf(proxy)

@chobits chobits changed the title perf(template): use more reasonable keepalive default value for Nginx tuning perf(proxy): use more reasonable keepalive default value for Nginx tuning Dec 20, 2023
@chobits
Copy link
Contributor Author

chobits commented Dec 20, 2023 •
edited
Loading

The performance test has passed. Whether tuning these parameters shows no significant changes in memory and RPS data. For more details, see KAG-3360's comment

@chobits @dndx
perf(proxy): use more reasonable keepalive default value for Nginx tu…
6574d87 
…ning

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360
@dndx dndx merged commit f7e6eee into master Dec 21, 2023
27 checks passed
@dndx dndx deleted the opt_keepalive_param branch December 21, 2023 10:22
@chobits chobits added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Dec 22, 2023
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/2.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/2.8.x
git worktree add -d .worktree/backport-12223-to-release/2.8.x origin/release/2.8.x
cd .worktree/backport-12223-to-release/2.8.x
git switch --create backport-12223-to-release/2.8.x
git cherry-pick -x f7e6eeefe006af11129d1b0e39a1c06449a53d42

@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.4.x with exitcode 1

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.2.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.2.x
git worktree add -d .worktree/backport-12223-to-release/3.2.x origin/release/3.2.x
cd .worktree/backport-12223-to-release/3.2.x
git switch --create backport-12223-to-release/3.2.x
git cherry-pick -x f7e6eeefe006af11129d1b0e39a1c06449a53d42

@team-gateway-bot
Copy link
Collaborator

'git push --set-upstream upstream cherry-pick-12223-to-master-to-upstream' failed with exit code 1

@team-gateway-bot
Copy link
Collaborator

You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID A341:3525:1529C6A:2BDC8D7:65A73030.

@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.5.x with exitcode 1

1 similar comment
@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.5.x with exitcode 1

github-actions bot pushed a commit that referenced this pull request Jan 17, 2024
@chobits @github-actions
perf(proxy): use higher default keepalive request value for Nginx tun…
0523017 
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.3.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.3.x
git worktree add -d .worktree/backport-12223-to-release/3.3.x origin/release/3.3.x
cd .worktree/backport-12223-to-release/3.3.x
git switch --create backport-12223-to-release/3.3.x
git cherry-pick -x f7e6eeefe006af11129d1b0e39a1c06449a53d42

@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.4.x:

@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.5.x with exitcode 1

@team-gateway-bot

This comment was marked as resolved.

Sign in to view
@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.5.x with exitcode 1

locao pushed a commit that referenced this pull request Jan 18, 2024
@chobits @locao
perf(proxy): use higher default keepalive request value for Nginx tun…
caab84f 
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
@kikito kikito mentioned this pull request Jan 24, 2024
Closed
3 tasks
@randmonkey randmonkey mentioned this pull request Jan 31, 2024
Merged
chobits added a commit that referenced this pull request Feb 5, 2024
@chobits
perf(proxy): use higher default keepalive request value for Nginx tun…
c2646de 
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
@chobits chobits mentioned this pull request Feb 5, 2024
Merged
3 tasks
@chobits chobits mentioned this pull request Feb 5, 2024
Merged
3 tasks
chobits added a commit that referenced this pull request Feb 5, 2024
@chobits
perf(proxy): use higher default keepalive request value for Nginx tun…
7d4c918 
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
chobits added a commit that referenced this pull request Feb 5, 2024
@chobits
perf(proxy): use higher default keepalive request value for Nginx tun…
43208ce 
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
This was referenced Feb 5, 2024
Closed
Merged
hanshuebner pushed a commit that referenced this pull request Feb 5, 2024
@chobits @hanshuebner
perf(proxy): use higher default keepalive request value for Nginx tun…
609874f 
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
chobits added a commit that referenced this pull request Feb 6, 2024
@chobits
perf(proxy): use higher default keepalive request value for Nginx tun…
4e44268 
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
windmgc pushed a commit that referenced this pull request Feb 6, 2024
@chobits @windmgc
perf(proxy): use higher default keepalive request value for Nginx tun…
2f9ee04 
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
chobits added a commit that referenced this pull request Feb 20, 2024
@chobits
perf(proxy): use higher default keepalive request value for Nginx tun…
bc4603d 
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
AndyZhang0707 added a commit that referenced this pull request Jul 18, 2024
@AndyZhang0707
Revert "perf(proxy): use higher default keepalive request value for N…
a5c97b0 
…ginx tuning (#12223)"

This reverts commit 609874f.
AndyZhang0707 added a commit that referenced this pull request Jul 26, 2024
@AndyZhang0707
Revert "perf(proxy): use higher default keepalive request value for N…
06424dc 
…ginx tuning (#12223)"

This reverts commit 609874f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@dndx dndx dndx approved these changes

@AndyZhang0707 AndyZhang0707 Awaiting requested review from AndyZhang0707

Assignees

@chobits chobits

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/templates size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chobits @bungle @team-gateway-bot @dndx @ADD-SP