Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport -> release/2.8.x] perf(proxy): use more reasonable keepalive default value for Nginx tuning #12533

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Feb 5, 2024

backport #12223
also backport this PR: https://github.com/Kong/kong-ee/pull/6507

Summary

Bumped default values of nginx_http_keepalive_requests and upstream_keepalive_max_requests to 10000.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-3360

dndx and others added 2 commits February 5, 2024 11:31
…11515)

Bumped the default value of `upstream_keepalive_pool_size` to `512` and `upstream_keepalive_max_requests` to `1000`.

FTI-4868
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
@chobits chobits changed the title Backport 12223 to release/2.8.x [backport -> release/2.8.x] perf(proxy): use more reasonable keepalive default value for Nginx tuning Feb 5, 2024
@hanshuebner hanshuebner merged commit 609874f into release/2.8.x Feb 5, 2024
31 checks passed
@hanshuebner hanshuebner deleted the backport-12223-to-release/2.8.x branch February 5, 2024 16:01
@chobits chobits restored the backport-12223-to-release/2.8.x branch February 6, 2024 03:35
@chobits chobits deleted the backport-12223-to-release/2.8.x branch February 6, 2024 03:38
@chobits chobits restored the backport-12223-to-release/2.8.x branch February 6, 2024 03:40
@chobits chobits deleted the backport-12223-to-release/2.8.x branch February 6, 2024 03:43
@chobits chobits added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Feb 6, 2024
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for release/2.8.x: couldn't find remote ref release/2.8.x.
Please ensure that this Github repo has a branch named release/2.8.x.

@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for release/2.8.x, because it was unable to create a new branch.

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream release/2.8.x
git worktree add -d .worktree/cherry-pick-12533-to-release/2.8.x-to-upstream upstream/release/2.8.x
cd .worktree/cherry-pick-12533-to-release/2.8.x-to-upstream
git checkout -b cherry-pick-12533-to-release/2.8.x-to-upstream
ancref=$(git merge-base c6bbc7d3ad194a45e0dd35609ae2fc13180a5dc8 43208ce6909fc7ce5149f9ed3196b9ca876303cd)
git cherry-pick -x $ancref..43208ce6909fc7ce5149f9ed3196b9ca876303cd

@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for release/2.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream release/2.8.x
git worktree add -d .worktree/cherry-pick-12533-to-release/2.8.x-to-upstream upstream/release/2.8.x
cd .worktree/cherry-pick-12533-to-release/2.8.x-to-upstream
git checkout -b cherry-pick-12533-to-release/2.8.x-to-upstream
ancref=$(git merge-base c6bbc7d3ad194a45e0dd35609ae2fc13180a5dc8 43208ce6909fc7ce5149f9ed3196b9ca876303cd)
git cherry-pick -x $ancref..43208ce6909fc7ce5149f9ed3196b9ca876303cd

@team-gateway-bot
Copy link
Collaborator

'git push --set-upstream upstream cherry-pick-12533-to-release/2.8.x-to-upstream' failed with exit code 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/templates size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants