[backport -> release/3.3.x] perf(proxy): use more reasonable keepalive default value for Nginx tuning #12531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chobits
changed the title
bungle
approved these changes
Feb 5, 2024
bungle
approved these changes
Feb 5, 2024
Water-Melon
approved these changes
Feb 5, 2024
chobits
added
the
cherry-pick kong-ee
…ing (#12223) Bumped default values of `nginx_http_keepalive_requests` and `upstream_keepalive_max_requests` to `10000`. KAG-3360 --------- Co-authored-by: Datong Sun <[email protected]> (cherry picked from commit f7e6eee)
chobits
force-pushed
the
backport-12223-to-release/3.3.x
branch
from
49acfe6
to
4e44268
Compare
chobits
commented
Feb 6, 2024
| @@ -0,0 +1,3 @@ | |||
| message: Bumped default values of `nginx_http_keepalive_requests` and `upstream_keepalive_max_requests` to `10000`. | |||
| type: performance | |||
| scope: Configuration | |||
There was a problem hiding this comment.
Although this PR modifies the default value of NGINX, it doesn't have a significant impact on the client's side. Therefore, I don't believe we need to categorize this feature as a breaking_change.
Typically, users won't notice this alteration. However, under stressful testing scenarios, they might observe an increase in NGINX's performance, specifically in RPS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #12223
also backport this PR: https://github.com/Kong/kong-ee/pull/6507
Summary
Bumped default values of
nginx_http_keepalive_requestsandupstream_keepalive_max_requeststo10000.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-3360