Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(electron): comment out auto-update code #1762

Closed
wants to merge 1 commit into from
Closed

fix(electron): comment out auto-update code #1762

wants to merge 1 commit into from

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Oct 30, 2023 •
edited
Loading

As requested in #1760

@daniellacosse daniellacosse changed the title fix: comment out auto-update code fix(electron): comment out auto-update code Oct 30, 2023
@daniellacosse daniellacosse marked this pull request as ready for review October 30, 2023 15:21
@daniellacosse daniellacosse requested a review from a team as a code owner October 30, 2023 15:21
@daniellacosse daniellacosse mentioned this pull request Oct 30, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

fortuna
fortuna requested changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove the update feature because that means users won't be able to update after they receive this change. Please revert.

If anything, we should consider a UI option that lets users enable/disable the autoupdate as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortuna fortuna fortuna requested changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniellacosse @fortuna