Bug in version 1.12 of Windows #1760

ahmadipiralvan · 2023-10-27T15:04:57Z

Hi
Outline on Windows was automatically updated to version 1.12. But after pressing the connection button, the internet of the entire system is disconnected and it will not be connected until the system is restarted. It is suggested to put settings to disable automatic update in the program so that if there is a bug, we can disable it.

cornzzy · 2023-10-28T07:42:53Z

The forced auto update makes no sense for this untested software. 1.12.0 was also released for iOS at the same and I had to tell every iOS client to reinstall to fix another issue.

It looks like there was an edit to how it handles server domains or DNS.

Beside OP's issue, sometimes the app sets custom IP addresses in the TAP adapter's IPv4 properties, suffocating itself. Users either have to set it back to auto or use Windows "Reset network" feature.

I appreciate that the software is free and that a lot of work has gone into it, but some of the decisions are baffling.

ldiazborg · 2023-10-28T11:30:03Z

It has problems in the Linux operating system too. I can't connect to any server, but when I download an older version, everything works.

PlatonB · 2023-10-28T13:12:07Z

I have the same problem. Windows 11, Outline 1.12.0, BlancVPN provider.

Talendar · 2023-10-28T20:29:22Z

I and some other users I know are also facing the same problem.

Talendar · 2023-10-28T20:34:36Z

@daniellacosse @sbruens @maddyhof

Please, have a look, when you got the time! This issue seems to be affecting many users.

jafari-dev · 2023-10-28T21:33:44Z

I have the same problem with Outline 1.12.0. My OS is Windows 11 Enterprise 22H2.

leadertv · 2023-10-29T06:27:22Z

The error appears when using dynamic keys. The error occurs for some users. The error was noticed on Windows 10 and 11.

homewsn · 2023-10-29T07:55:43Z

Same problem, Outline client version 1.12.0 (471355), Windows 10 22H2. But I can restore my usual Internet connection by killing the service process OutlineService.exe.

ahmadipiralvan · 2023-10-29T13:44:51Z

It seems that something must be done. At least disable auto-update!
@fortuna @daniellacosse @sbruens @maddyhof @jyyi1

jafari-dev · 2023-10-29T18:16:21Z

@ahmadipiralvan I found an open issue from 5 years ago about disabling auto-update, but it seems no one cares! I also left a comment for them.

#449 (comment)

ahmadipiralvan · 2023-10-29T20:15:43Z

@ahmadipiralvan I found an open issue from 5 years ago about disabling auto-update, but it seems no one cares! I also left a comment for them.

#449 (comment)

It seems that the project has been abandoned! No one is responsible...

transcendreamer · 2023-10-30T07:43:59Z

As a temporary workaround I reinstall outline-client-1.10.0.exe on each reboot before connecting and using old version until next reboot, dumb yes, but works.

homewsn · 2023-10-30T13:40:06Z

@transcendreamer
I installed outline-client-1.10.0.exe and then changed the file name C:\Program Files (x86)\Outline\resources\app-update.yml to anything else. The auto updater turned off.

daniellacosse · 2023-10-30T14:45:14Z

Hey everyone, sorry for being away over the weekend. Looking at this now.

outline-ipc-start-proxying is an IPC call from electron. It's not my area, but maybe electron is out of date? @jyyi1

We have a QA team that should have caught this, as to why that's not the case is another mystery.

You can see an imperfect list of the updates in 1.12 here, in case anyone else wants to hazard a guess - https://github.com/Jigsaw-Code/outline-client/releases/tag/client_windows%2Fv1.12.0. Was going to announce this today/tomorrow once Android starts to roll out.

Would y'all prefer we just turned off auto update wholesale, at least for now? It's annoying for us to maintain as well.

daniellacosse · 2023-10-30T15:05:13Z

The forced auto update makes no sense for this untested software. 1.12.0 was also released for iOS at the same and I had to tell every iOS client to reinstall to fix another issue.

It looks like there was an edit to how it handles server domains or DNS.

Beside OP's issue, sometimes the app sets custom IP addresses in the TAP adapter's IPv4 properties, suffocating itself. Users either have to set it back to auto or use Windows "Reset network" feature.

I appreciate that the software is free and that a lot of work has gone into it, but some of the decisions are baffling.

I've paused the iOS rollout - what issue were you seeing on iOS?

Talendar · 2023-10-30T15:13:21Z

Would y'all prefer we just turned off auto update wholesale, at least for now? It's annoying for us to maintain as well.

Yes, please!

daniellacosse · 2023-10-30T15:22:33Z

PR to disable autoupdate here: #1762

Working on rolling back Windows - will react to this comment when done.

fortuna · 2023-10-30T15:40:05Z

I'm sorry all for the issue with Windows.

@daniellacosse has reverted the Windows client, so you should be able to go back to the previous version and not get updated.

We can't remove the update feature. That will force users to manually go to the site and download a new version whenever they need, which is very bad.

We can consider adding UI to let the user enable or disable the auto-updates. We are a small team, and it would be helpful if someone in the community could contribute that.

fortuna · 2023-10-30T15:44:35Z

@leadertv thanks for the helpful comment. What makes you think the issue is with dynamic keys? Are static keys working?

leadertv · 2023-10-30T16:23:04Z

@leadertv thanks for the helpful comment. What makes you think the issue is with dynamic keys? Are static keys working?

Standard static keys work, which contain an IP address and port. In some cases, a static key works inside of which the domain is specified instead of the IP. The problem only affects the PC client. Everything works fine on iPhone and Android.
I believe the problem is related to dynamic keys and the hosts in them, judging by the answers from JSON, it depends on the host on the server, if the host contains a domain, an error appears, if the IP is in the host, then there is no error, but then in this case, in the client there will be display the IP after connecting, instead of the domain.

daniellacosse · 2023-10-30T17:46:51Z

Everything works fine on iPhone and Android.

iPhone is only rolled out to 10% and Android is not in rollout yet, FYI.

Do static keys with a domain work?

daniellacosse · 2023-10-30T18:07:09Z

We've got a new 1.12.1 version going out to our QA team now, with an emphasis on reproducing this exact issue (dynamic keys with a hostname). Will continue to update this thread.

daniellacosse · 2023-10-30T18:25:29Z

Everything works fine on iPhone and Android.

iPhone is only rolled out to 10% and Android is not in rollout yet, FYI.

Do static keys with a domain work?

Confirmed that static keys with a domain don't work either.

daniellacosse · 2023-10-30T18:47:38Z

Found the issue on Ubuntu as well and rolled that back, too.

fortuna · 2023-10-30T18:58:36Z

Thanks again @leadertv, that's really helpful

To summarize:

Android and iOS are fine.
Windows is having issues
The issue is not static vs dynamic keys, but whether config in the key is using an IP or domain name.
Linux is unknown - It would be helpful is someone could validate Linux.

Also I'll point out different cases:

static key with ip
static key with domain
dynamic key (location with domain), with config using IP
dynamic key (location with domain), with config using domain

Note that the dynamic key itself (the location of the config) must always have a domain, since we don't support IPs for the config location.

It seems cases 2 and 4 above are the issues.

daniellacosse · 2023-10-30T19:02:27Z

Thanks again @leadertv, that's really helpful

To summarize:

Android and iOS are fine.

Windows is having issues

The issue is not static vs dynamic keys, but whether config in the key is using an IP or domain name.

Linux is unknown - It would be helpful is someone could validate Linux.

Also I'll point out different cases:

static key with ip

static key with domain

dynamic key (location with domain), with config using IP

dynamic key (location with domain), with config using domain

Note that the dynamic key itself (the location of the config) must always have a domain, since we don't support IPs for the config location.

It seems cases 2 and 4 above are the issues.

@jyyi1 has tested ubuntu and confirmed it also doesn't work, I rolled it back already.

fortuna · 2023-10-30T19:07:54Z

@jyyi1 tested domain names using nip.io and found the following error:

could not connect: Error (could not create route to proxy: command exited with 1 (stdout: Invalid prefix parameter ([REDACTED].nip.io/32).  Prefix should be of the form <IPv4 address>/[0-32]., stderr: )

Code: https://github.com/Jigsaw-Code/outline-client/blob/07a5651d4d8ce2e3b91706543f60aff816611153/tools/OutlineService/OutlineService/OutlineService.cs#L419

It seems the issue is that we are passing the shadowsocks host as is to the routing code without resolving it first.

That is not a new bug though. It was likely not introduced by 1.12. Perhaps providers started using domain names for servers, and that triggered the issue that was already there.

daniellacosse · 2023-10-30T19:09:13Z

@jyyi1 tested domain names using nip.io and found the following error:
could not connect: Error (could not create route to proxy: command exited with 1 (stdout: Invalid prefix parameter ([REDACTED].nip.io/32).  Prefix should be of the form <IPv4 address>/[0-32]., stderr: ) 
Code:

https://github.com/Jigsaw-Code/outline-client/blob/07a5651d4d8ce2e3b91706543f60aff816611153/tools/OutlineService/OutlineService/OutlineService.cs#L419

It seems the issue is that we are passing the shadowsocks host as is to the routing code without resolving it first.

That is not a new bug though. It was likely not introduced by 1.12. Perhaps providers started using domain names for servers, and that triggered the issue that was already there.

@jyyi1 and I think this might be the culprit: https://github.com/Jigsaw-Code/outline-client/pull/1663/files#diff-6d2de722e11e66d05f50ffd3437dd67abd336c0089dc8787e762d3dc332ee739L484

fortuna · 2023-10-30T19:13:11Z

The workaround is to ask your server operator to roll back the use of domain names in the config file.

I'll note that the OutlineVpnBot and the outline[.]network site are not official. The Outline team is not responsible for those services.

fortuna · 2023-10-30T19:15:20Z

@homewsn @transcendreamer were you able to reproduce the issue, and verify whether the same config works on Windows Client 1.10?

I believe the bug has always been there.

Edit: the issue was introduced in July, and the fix is under way: #1763

transcendreamer · 2023-10-30T19:19:36Z

@fortuna , right now I'm connected to this one and it works OK on 1.10:
ss://YWVzLTEyOC1nY206c2hhZG93c29ja3M=@ak1833.www.outline.network.fr8678825324247b8176d59f83c30bd94d23d2e3ac5cd4a743bkwqeikvdyufr.cyou:443#www.outline.network%20(GB)

it's from outline[.]network

daniellacosse · 2023-10-30T19:20:12Z

@jyyi1 has drafted a fix: https://github.com/Jigsaw-Code/outline-client/pull/1763/files

daniellacosse · 2023-10-30T20:34:30Z

The fix has been merged and sent to QA.

q1LLa · 2023-11-01T09:24:26Z

The fix has been merged and sent to QA.

How long to wait for the update ?

leadertv · 2023-11-01T09:27:46Z

The fix has been merged and sent to QA.

How long to wait for the update ?

At the moment you can download version 1.11 from the website. This version works correctly with dynamic keys.

q1LLa · 2023-11-01T09:35:01Z

The fix has been merged and sent to QA.

How long to wait for the update ?

At the moment you can download version 1.11 from the website. This version works correctly with dynamic keys.

What is the time frame for an update in days?

daniellacosse · 2023-11-01T15:56:57Z

The fix has been merged and sent to QA.

How long to wait for the update ?

At the moment you can download version 1.11 from the website. This version works correctly with dynamic keys.

What is the time frame for an update in days?

QA approved and I've ran our release script - the update should be out now.

q1LLa · 2023-11-01T16:43:50Z

The fix has been merged and sent to QA.

How long to wait for the update ?

At the moment you can download version 1.11 from the website. This version works correctly with dynamic keys.

What is the time frame for an update in days?

QA approved and I've ran our release script - the update should be out now.

I still have Version 1.12.0 (471355)

Which one should appear in the update?

daniellacosse · 2023-11-01T16:56:43Z

The fix has been merged and sent to QA.

How long to wait for the update ?

At the moment you can download version 1.11 from the website. This version works correctly with dynamic keys.

What is the time frame for an update in days?

QA approved and I've ran our release script - the update should be out now.

I still have Version 1.12.0 (471355)

Which one should appear in the update?

You can download it directly here https://s3.amazonaws.com/outline-releases/client_windows/v1.12.1/Outline-Client.exe

ahmadipiralvan · 2023-11-02T00:53:30Z

You can download it directly here https://s3.amazonaws.com/outline-releases/client_windows/v1.12.1/Outline-Client.exe

Thank you @daniellacosse
It has been a while since the update files (apk, exe...) are not published in the GitHub release section. I would be grateful if you include the installation files in the releases.

By the way, does the team have a plan for the following issue?
#1553

daniellacosse · 2023-11-02T17:57:28Z

It has been a while since the update files (apk, exe...) are not published in the GitHub release section. I would be grateful if you include the installation files in the releases.

Unfortunately our binaries got too big for us to be able to check them in with git. Git LFS does not have the same surface area and is easier to censor. Would it be helpful if I were to add a note to outline-releases to say that it is in fact partially deprecated for this reason?

Edit: Ah, if you mean the releases tab here on the outline-client Github, I could add it as a new deployment target for our internal release scripts.

By the way, does the team have a plan for the following issue?
#1553

We really appreciate the time you took to spell this out but in its current format it doesn't fit into our prioritization system. We'll need to break it down into individual tickets so it can be properly prioritized.

ahmadipiralvan · 2023-11-04T12:19:19Z

You can download it directly here https://s3.amazonaws.com/outline-releases/client_windows/v1.12.1/Outline-Client.exe

It seems that the problem is still not fixed on iOS.
Is there a solution for it?
The latest version in the AppStore is 1.12.0.

ahmadipiralvan · 2023-11-04T12:31:38Z

Edit: Ah, if you mean the releases tab here on the outline-client Github, I could add it as a new deployment target for our internal release scripts.

Yes, I meant the outline-client/releases files.
(exe, appimage, apk ...)
It would be great if every version is available on github like before.

Many people in countries with internet restrictions do not have access to the https://getoutline.org and https://outline.network websites because these websites are blocked there and cannot download the program. For example, even Google Play is blocked in Iran. But usually github is inevitably available in most countries and they cannot block it easily. For this reason, many people have the ability to download the program only through GitHub.

fortuna · 2023-11-06T16:07:17Z

@ahmadipiralvan the official download links are on Amazon S3. Please see https://www.reddit.com/r/outlinevpn/wiki/index/download_links/

Maintaining the Github release is confusing, as there are multiple binaries that can be released separately. So we opted for S3.

maddyhof · 2023-11-06T16:09:47Z

@ahmadipiralvan We did not see this issue on iOS when we tested it. If you do, please open a new issue so we can investigate it further.

FYI https://outline.network is not affiliated with the Outline team and we cannot assist users experiencing issues with that service.

maddyhof · 2023-11-06T16:11:40Z

Closing this issue now that we've released Client 1.12.1 for Windows and Linux

rustam-python · 2023-12-13T16:11:19Z

I have same error with 1.12.1 (471860) and Windows 11.

somebodywashere · 2024-01-07T15:00:25Z

This problem is still there and not solved, why closing an issue?

jyyi1 · 2024-01-08T21:34:14Z

Hi @rustam-python @somebodywashere , we found and fixed one thing that was causing the problem in 1.12.0 (100% reproducible), but it might not be the only cause. The same error (but with a different root cause) might also happen in version 1.12.1 (but we have not reproduced it on our end), and we're tracking it here: #1783

ahmadipiralvan added the bug Something is broken, we are tracking it label Oct 27, 2023

Talendar mentioned this issue Oct 28, 2023

windows 10: error: error invoking remote method 'outline-ipc-start-proxying': error: unknown nativeerror error Jigsaw-Code/outline-server#1431

Closed

daniellacosse added the !BLOCKING RELEASE! label Oct 30, 2023

daniellacosse mentioned this issue Oct 30, 2023

fix(electron): comment out auto-update code #1762

Closed

jyyi1 mentioned this issue Oct 30, 2023

fix(electron): 🩹 fix connection issue of domain name keys #1763

Merged

maddyhof removed the !BLOCKING RELEASE! label Nov 1, 2023

maddyhof added os/windows os/linux failure/connect labels Nov 6, 2023

maddyhof closed this as completed Nov 6, 2023

Bug in version 1.12 of Windows #1760

Bug in version 1.12 of Windows #1760

Comments

ahmadipiralvan commented Oct 27, 2023

cornzzy commented Oct 28, 2023

ldiazborg commented Oct 28, 2023

PlatonB commented Oct 28, 2023

Talendar commented Oct 28, 2023

Talendar commented Oct 28, 2023

jafari-dev commented Oct 28, 2023

leadertv commented Oct 29, 2023

homewsn commented Oct 29, 2023

ahmadipiralvan commented Oct 29, 2023

jafari-dev commented Oct 29, 2023

ahmadipiralvan commented Oct 29, 2023 • edited Loading

transcendreamer commented Oct 30, 2023

homewsn commented Oct 30, 2023

daniellacosse commented Oct 30, 2023 • edited Loading

daniellacosse commented Oct 30, 2023

Talendar commented Oct 30, 2023

daniellacosse commented Oct 30, 2023

fortuna commented Oct 30, 2023 • edited Loading

fortuna commented Oct 30, 2023

leadertv commented Oct 30, 2023

daniellacosse commented Oct 30, 2023

daniellacosse commented Oct 30, 2023 • edited Loading

daniellacosse commented Oct 30, 2023

daniellacosse commented Oct 30, 2023

fortuna commented Oct 30, 2023 • edited Loading

daniellacosse commented Oct 30, 2023

fortuna commented Oct 30, 2023 • edited Loading

daniellacosse commented Oct 30, 2023

fortuna commented Oct 30, 2023

fortuna commented Oct 30, 2023 • edited Loading

transcendreamer commented Oct 30, 2023 • edited Loading

daniellacosse commented Oct 30, 2023

daniellacosse commented Oct 30, 2023

q1LLa commented Nov 1, 2023

leadertv commented Nov 1, 2023

q1LLa commented Nov 1, 2023

daniellacosse commented Nov 1, 2023

q1LLa commented Nov 1, 2023

daniellacosse commented Nov 1, 2023

ahmadipiralvan commented Nov 2, 2023

daniellacosse commented Nov 2, 2023 • edited Loading

ahmadipiralvan commented Nov 4, 2023

ahmadipiralvan commented Nov 4, 2023

fortuna commented Nov 6, 2023

maddyhof commented Nov 6, 2023 • edited Loading

maddyhof commented Nov 6, 2023

rustam-python commented Dec 13, 2023

somebodywashere commented Jan 7, 2024

jyyi1 commented Jan 8, 2024

ahmadipiralvan commented Oct 29, 2023 •

edited

Loading

daniellacosse commented Oct 30, 2023 •

edited

Loading

fortuna commented Oct 30, 2023 •

edited

Loading

daniellacosse commented Oct 30, 2023 •

edited

Loading

fortuna commented Oct 30, 2023 •

edited

Loading

fortuna commented Oct 30, 2023 •

edited

Loading

fortuna commented Oct 30, 2023 •

edited

Loading

transcendreamer commented Oct 30, 2023 •

edited

Loading

daniellacosse commented Nov 2, 2023 •

edited

Loading

maddyhof commented Nov 6, 2023 •

edited

Loading