Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): comment out auto-update code #1762

Closed
wants to merge 1 commit into from
Closed

fix(electron): comment out auto-update code #1762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/electron/build.action.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import minimist from 'minimist';
// import minimist from 'minimist';
import {getBuildParameters} from '../build/get_build_parameters.mjs';
import {runAction} from '../build/run_action.mjs';
import electron, {Platform} from 'electron-builder';
Expand All @@ -27,7 +27,7 @@ const ELECTRON_PLATFORMS = ['linux', 'windows'];

export async function main(...parameters) {
const {platform, buildMode, versionName} = getBuildParameters(parameters);
const {autoUpdateProvider = 'generic', autoUpdateUrl} = minimist(parameters);
// const {autoUpdateProvider = 'generic', autoUpdateUrl} = minimist(parameters);

if (!ELECTRON_PLATFORMS.includes(platform)) {
throw new TypeError(
Expand All @@ -41,12 +41,12 @@ export async function main(...parameters) {
console.warn(`WARNING: building "${platform}" in [DEBUG] mode. Do not publish this build!!`);
}

if (buildMode === 'release' && !autoUpdateUrl) {
throw new TypeError(
"You need to add an electron-builder compliant auto-update url via an 'autoUpdateUrl' flag." +
'See here: https://www.electron.build/configuration/publish#publishers'
);
}
// if (buildMode === 'release' && !autoUpdateUrl) {
// throw new TypeError(
// "You need to add an electron-builder compliant auto-update url via an 'autoUpdateUrl' flag." +
// 'See here: https://www.electron.build/configuration/publish#publishers'
// );
// }

await runAction('www/build', ...parameters);
await runAction('electron/build_main', ...parameters);
Expand All @@ -66,12 +66,12 @@ export async function main(...parameters) {
targets: Platform[platform.toLocaleUpperCase()].createTarget(),
config: {
...electronConfig,
publish: autoUpdateUrl
? {
provider: autoUpdateProvider,
url: autoUpdateUrl,
}
: undefined,
// publish: autoUpdateUrl
// ? {
// provider: autoUpdateProvider,
// url: autoUpdateUrl,
// }
// : undefined,
generateUpdatesFilesForAllChannels: buildMode === 'release',
extraMetadata: {
...electronConfig.extraMetadata,
Expand Down
Loading