Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 pass disabled folders plugin to frontend #6205

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Aug 19, 2024

What do these changes do?

  • 🐛 pass disabled folders plugin to frontend

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 19, 2024 08:28
@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 19, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Eisbock milestone Aug 19, 2024
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to go to prod?

Copy link

@matusdrobuliak66
Copy link
Contributor Author

does this need to go to prod?

no it doesn't 👍

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.0%. Comparing base (cafbf96) to head (e7d728c).
Report is 451 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6205      +/-   ##
=========================================
- Coverage    84.5%   82.0%    -2.6%     
=========================================
  Files          10     577     +567     
  Lines         214   29433   +29219     
  Branches       25     234     +209     
=========================================
+ Hits          181   24156   +23975     
- Misses         23    5217    +5194     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 87.5% <ø> (+2.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../simcore_service_webserver/application_settings.py 98.2% <ø> (ø)

... and 586 files with indirect coverage changes

auto-merge was automatically disabled August 20, 2024 11:56

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants