🎨 [Frontend] Improve blocked card's UX #6207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore into enh/blocked-studies
…ore into enh/blocked-studies
odeimaiz
requested review from
calys,
giancarloromeo,
GitHK,
elisabettai,
pcrespov,
sanderegg and
matusdrobuliak66
|
ignapas
approved these changes
Aug 21, 2024
|
love it! |
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
A Study card in the dashboard can be blocked for multiple reasons: Study in use, unknown services. being duplicated...
At the moment the blocking mechanism is not consistent. This PR makes it more consistent and, since the PATCH method on the study resource is implemented and tested, it also allows users make some not blocked operations on it:
If a study is open by collaborator B, user A still can:
If a study is blocked because there are unknown services (waiting for permissions on some services), let users tune the metadata that doesn't touch the workbench sub-object and also delete it.
Bonus:
Study in use:
Unknown services:
Related issue/s
closes #5752
How to test
Dev-ops checklist