Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛🎨 Pass WEBSERVER_FOLDERS flag to frontend and use it #6206

Merged
merged 7 commits into from
Aug 19, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 19, 2024

What do these changes do?

🐛 Pass disabled folders plugin to frontend
🎨 Frontend uses the plugin flag
🐛 Frontend: do not fetch folders for guest users

Related issue/s

includes #6205

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Aug 19, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Aug 19, 2024
@odeimaiz odeimaiz added this to the Eisbock milestone Aug 19, 2024
…ub.com:matusdrobuliak66/osparc-simcore into enh/use-folders-enabled-flag
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Use backend's folders_enabled flag 🐛🎨 Webserver_Folders flag to frontend and use it Aug 19, 2024
@odeimaiz odeimaiz marked this pull request as ready for review August 19, 2024 09:48
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link

@odeimaiz odeimaiz enabled auto-merge (squash) August 19, 2024 09:50
@odeimaiz odeimaiz changed the title 🐛🎨 Webserver_Folders flag to frontend and use it 🐛🎨 Pass Webserver_Folders flag to frontend and use it Aug 19, 2024
@odeimaiz odeimaiz changed the title 🐛🎨 Pass Webserver_Folders flag to frontend and use it 🐛🎨 Pass WEBSERVER_FOLDERS flag to frontend and use it Aug 19, 2024
@odeimaiz odeimaiz disabled auto-merge August 19, 2024 09:50
@odeimaiz odeimaiz enabled auto-merge (squash) August 19, 2024 09:50
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.0%. Comparing base (cafbf96) to head (3726eac).
Report is 445 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6206      +/-   ##
=========================================
- Coverage    84.5%   82.0%    -2.6%     
=========================================
  Files          10     577     +567     
  Lines         214   29433   +29219     
  Branches       25     234     +209     
=========================================
+ Hits          181   24158   +23977     
- Misses         23    5215    +5192     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 87.5% <ø> (+2.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../simcore_service_webserver/application_settings.py 98.2% <ø> (ø)

... and 586 files with indirect coverage changes

@odeimaiz odeimaiz merged commit 719aed9 into ITISFoundation:master Aug 19, 2024
57 checks passed
giancarloromeo pushed a commit to giancarloromeo/osparc-simcore that referenced this pull request Aug 19, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 21, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants