-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix frontend deploy workflow #4977
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5abc9ed
Refactor FE deploy workflow
matthewelwell b526817
Testing
matthewelwell 167f042
Fix / simplify test process
matthewelwell 90fbcaf
Fix inputs definition
matthewelwell 5598b73
Add working directory
matthewelwell 533934e
Remove testing logic
matthewelwell f0ae8c3
Explicitly set npm build env
matthewelwell 3987e6d
Explicit environment input names
matthewelwell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # reusable workflow | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| environment: | ||
| type: string | ||
| description: Github environment to use for secret / variable access | ||
| required: true | ||
|
|
||
| defaults: | ||
| run: | ||
| working-directory: frontend | ||
|
|
||
| jobs: | ||
| deploy: | ||
| runs-on: ubuntu-latest | ||
| environment: ${{ inputs.environment }} | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Cloning repo | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js 16.x | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 16.x | ||
|
|
||
| - name: Cache dependencies | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: ~/.npm | ||
| key: npm-${{ hashFiles('package-lock.json') }} | ||
| restore-keys: npm- | ||
|
|
||
| - name: Deploy to Vercel | ||
| env: | ||
| VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }} | ||
| VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }} | ||
| ENV: prod | ||
| run: | | ||
| npm ci --only=prod | ||
| npm run env | ||
| npm run bundle | ||
| echo ${{ github.sha }} > CI_COMMIT_SHA | ||
| npm install --global [email protected] | ||
| vercel --prod --token ${{ secrets.VERCEL_TOKEN }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,10 +8,6 @@ on: | |
| - frontend/** | ||
| - .github/** | ||
|
|
||
| defaults: | ||
| run: | ||
| working-directory: frontend | ||
|
|
||
| jobs: | ||
| run-tests: | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -33,70 +29,15 @@ jobs: | |
| environment: prod | ||
|
|
||
| deploy-production: | ||
| runs-on: ubuntu-latest | ||
| name: Deploy to Vercel Production | ||
| environment: production | ||
| needs: run-tests | ||
|
|
||
| steps: | ||
| - name: Cloning repo | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js 16.x | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 16.x | ||
|
|
||
| - name: Cache dependencies | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: ~/.npm | ||
| key: npm-${{ hashFiles('package-lock.json') }} | ||
| restore-keys: npm- | ||
|
|
||
| - name: Deploy to Vercel | ||
| env: | ||
| VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }} | ||
| VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }} | ||
| ENV: prod | ||
| run: | | ||
| npm ci --only=prod | ||
| npm run env | ||
| npm run bundle | ||
| echo ${{ github.sha }} > CI_COMMIT_SHA | ||
| vercel --prod --token ${{ secrets.VERCEL_TOKEN }} | ||
| uses: ./.github/workflows/.reusable-frontend-deploy.yml | ||
| with: | ||
| environment: prod | ||
|
|
||
| deploy-demo: | ||
| runs-on: ubuntu-latest | ||
| name: Deploy to Vercel Demo | ||
| environment: demo | ||
| needs: run-tests | ||
|
|
||
| steps: | ||
| - name: Cloning repo | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js 16.x | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 16.x | ||
|
|
||
| - name: Cache dependencies | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: ~/.npm | ||
| key: npm-${{ hashFiles('package-lock.json') }} | ||
| restore-keys: npm- | ||
|
|
||
| - name: Deploy to Vercel | ||
| env: | ||
| VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }} | ||
| VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }} | ||
| ENV: prod | ||
| run: | | ||
| npm ci --only=prod | ||
| npm run env | ||
| npm run bundle | ||
| echo ${{ github.sha }} > CI_COMMIT_SHA | ||
| npm install --global [email protected] | ||
| vercel --prod --token ${{ secrets.VERCEL_TOKEN }} | ||
| uses: ./.github/workflows/.reusable-frontend-deploy.yml | ||
| with: | ||
| environment: demo | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be worth mentioning this is a production workflow in the filename if this isn't an input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, fair point. I've added an input for this as I hope that we can use this for staging in the future rather than having different workflows for staging / production and demo.