ci: fix frontend deploy workflow #4977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
matthewelwell
had a problem deploying
to
production
GitHub Actions
Failure
github-actions
bot
added
ci-cd
github-actions
bot
added
ci-cd
github-actions
bot
added
ci-cd
github-actions
bot
added
ci-cd
matthewelwell
requested review from
a team and
tiagoapolo
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4977 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 1191 1191
Lines 41630 41630
=======================================
Hits 40546 40546
Misses 1084 1084 ☔ View full report in Codecov by Sentry. |
kyle-ssg
reviewed
Jan 8, 2025
| env: | ||
| VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }} | ||
| VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }} | ||
| ENV: prod |
There was a problem hiding this comment.
I think it might be worth mentioning this is a production workflow in the filename if this isn't an input
There was a problem hiding this comment.
Yeah, fair point. I've added an input for this as I hope that we can use this for staging in the future rather than having different workflows for staging / production and demo.
github-actions
bot
added
ci-cd
github-actions
bot
added
ci-cd
kyle-ssg
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes frontend deployment workflow, and refactors for code reuse.
How did you test this code?
Triggered the workflow (without actually deploying) for the new branch (see here)